You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Review the merged #12624 before the next release #13050
@bardiharborow This is True! However, we are also running many more tests. Ideas:
I'm not using docker containers for the selenium tests, to streamline the test process. Maybe switching back to docker containers would speed this up.
Selenium tests are now run for every pull request. Including rulesets. If this is mostly a disruption of ruleset work, then we should probably just turn off selenium tests for the ruleset PRs.
The longest runtime of an induvidual test is actually just 3 minutes. But Travis is very slow to get them all started. The tests would be fast if Travis ran them all in parallel.
Selenium tests are now run for every pull request. Including rulesets. If this is mostly a disruption of ruleset work, then we should probably just turn off selenium tests for the ruleset PRs.
I do think we should switch this, since the majority of PRs are for rulesets. It seems silly to run the selenium tests when no core code has changed.
Activity
bardiharborow commentedon Oct 14, 2017
One comment I will make is that build times have been slowed way down by these changes.
cowlicks commentedon Oct 17, 2017
@bardiharborow This is True! However, we are also running many more tests. Ideas:
Hainish commentedon Oct 27, 2017
I do think we should switch this, since the majority of PRs are for rulesets. It seems silly to run the selenium tests when no core code has changed.