Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Review the merged #12624 before the next release #13050

Closed

Description

@cowlicks

Type: other

#12624 was merged to make reviewing PR's easier while @Hainish is out. It should be reviewed before the next release.

Activity

  1. bardiharborow commented on Oct 14, 2017

    @bardiharborow
    Contributor

    One comment I will make is that build times have been slowed way down by these changes.

  2. cowlicks commented on Oct 17, 2017

    @cowlicks
    ContributorAuthor

    @bardiharborow This is True! However, we are also running many more tests. Ideas:

    • I'm not using docker containers for the selenium tests, to streamline the test process. Maybe switching back to docker containers would speed this up.
    • Selenium tests are now run for every pull request. Including rulesets. If this is mostly a disruption of ruleset work, then we should probably just turn off selenium tests for the ruleset PRs.
    • The longest runtime of an induvidual test is actually just 3 minutes. But Travis is very slow to get them all started. The tests would be fast if Travis ran them all in parallel.
  3. Hainish commented on Oct 27, 2017

    @Hainish
    Member

    Selenium tests are now run for every pull request. Including rulesets. If this is mostly a disruption of ruleset work, then we should probably just turn off selenium tests for the ruleset PRs.

    I do think we should switch this, since the majority of PRs are for rulesets. It seems silly to run the selenium tests when no core code has changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions