Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Warning about missing specification of browser_style #12775

Closed

Description

@genodeftest

Steps to reproduce:

  1. have a fresh and clean firefox profile (firefox 55.0.3 in my case) started from command line
  2. install HTTPS Everywhere (Version 2017.9.12 from AMO)
  3. have a look at the output

What happens:
Every time this addon is installed or firefox is started, I get this warning:
Please specify whether you want browser_style or not in your browser_action options.
This warning is sometimes prefixed with [timestamp] addons.xpi WARN and sometimes with [timestamp] addons.webextension.https-everywhere@eff.org WARN .

What should happen:
No warning

Additional info:
browser_action is set in https://github.com/EFForg/https-everywhere/blob/master/chromium/manifest.json#L18.

It doesn't look like the MDN docs have a related documentation:
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/browserAction
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/user_interface/Browser_action

Activity

  1. changed the title [-]Warning about missing specification of browser_actions[/-] [+]Warning about missing specification of browser_style[/+] on Sep 27, 2017
  2. ExE-Boss commented on May 25, 2018

    @ExE-Boss
    Contributor
  3. genodeftest commented on May 28, 2018

    @genodeftest
    Author

    #12776 has a fix which is now conflict-freed and ready to merge imho.

  4. pipboy96 commented on Jun 5, 2019

    @pipboy96
    Contributor

    I can no longer reproduce the warning in Chrome, FF and Tor Browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions