Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Sync extra rules and enabledness between multiple machines using the same google account #1022

Closed

Description

@fnkr

Please add the ability to sync own rules and enabled/disabled rules.
https://developer.chrome.com/extensions/storage

Activity

  1. reedy commented on Feb 15, 2015

    @reedy
    Contributor

    You mean between multiple computers when logged in with your google account?

  2. changed the title [-]Sync[/-] [+]Sync extra rules and enabledness between multiple machines using the same google accoun[/+] on Feb 15, 2015
  3. changed the title [-]Sync extra rules and enabledness between multiple machines using the same google accoun[/-] [+]Sync extra rules and enabledness between multiple machines using the same google accountt[/+] on Feb 15, 2015
  4. changed the title [-]Sync extra rules and enabledness between multiple machines using the same google accountt[/-] [+]Sync extra rules and enabledness between multiple machines using the same google account[/+] on Feb 15, 2015
  5. fnkr commented on Feb 15, 2015

    @fnkr
    Author

    Yes.

  6. reedy commented on Feb 16, 2015

    @reedy
    Contributor

    I guess something similar could/should be done for FF sync too

  7. diracdeltas commented on Mar 8, 2015

    @diracdeltas
    Contributor

    This is probably a good idea; I think the % of chrome users who don't want to sync data between logged-in google-enabled Chrome profiles would be negligible.

    Right now we use window.localStorage. Switching that over to the chrome.storage.sync API should be easy.

    However, note that window.localStorage has 5MB of storage available per origin in Chrome, whereas chrome.storage.sync only lets HTTPS Everywhere have 100KB. That is probably not enough, unless you only sync diffs to the default rules set (user-added/enabled/disabeld rules).

  8. fnkr commented on Mar 8, 2015

    @fnkr
    Author

    For those people who dont want to sync with Google we could use chrome.storage.local (opt-out), the API is identical to chrome.storage.sync but the data stays on the local computer.

    Furthermore, I think syncing the difference between the default ruleset and the user ruleset would be the best option anyway.

  9. semenko commented on Mar 27, 2015

    @semenko
    Contributor

    With #1295 merged, we now declare the storage API in the manifest.

    I agree the RE the privacy implications here -- users who don't want HTTPSe rule status synced between computers probably aren't signed into Chrome in the first place -- in which case Chrome defaults to chrome.storage.local.

  10. fnkr commented on Mar 27, 2015

    @fnkr
    Author

    @privacy: If the user does not want Google to have the his data he is able to encrypt all synced data locally by setting a custom passpharse.

  11. semenko commented on Mar 27, 2015

    @semenko
    Contributor

    Not yet -- no code has been written. Pull requests welcome if you'd like to help! :)

  12. TheNavigat commented on Aug 23, 2015

    @TheNavigat
    Contributor

    If I'm not mistake, getStoredUserRules in chromium/background.js loads only manually entered rules. Also, addNewRule adds a new rule to the local storage. If that is correct, then it should be easy to use Chrome's API to store the user-added rules in the cloud. In other words, we don't really need to "only sync diffs to the default rules set".

    Can someone confirm/explain this, please?

  13. jsha commented on Aug 23, 2015

    @jsha
    Member

    That's correct. We're also talking about the ability to enable or disable a ruleset. It would be nice if the "is this ruleset enabled" bit could be synced, but only for rulesets where the enable/disable status is different than the default.

  14. pipboy96 commented on Mar 28, 2019

    @pipboy96
    Contributor

    This is most likely already implemented since we always use synced storage if it's available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions