You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Sync extra rules and enabledness between multiple machines using the same google account #1022
changed the title [-]Sync extra rules and enabledness between multiple machines using the same google accoun[/-][+]Sync extra rules and enabledness between multiple machines using the same google accountt[/+]on Feb 15, 2015
changed the title [-]Sync extra rules and enabledness between multiple machines using the same google accountt[/-][+]Sync extra rules and enabledness between multiple machines using the same google account[/+]on Feb 15, 2015
This is probably a good idea; I think the % of chrome users who don't want to sync data between logged-in google-enabled Chrome profiles would be negligible.
Right now we use window.localStorage. Switching that over to the chrome.storage.sync API should be easy.
However, note that window.localStorage has 5MB of storage available per origin in Chrome, whereas chrome.storage.sync only lets HTTPS Everywhere have 100KB. That is probably not enough, unless you only sync diffs to the default rules set (user-added/enabled/disabeld rules).
For those people who dont want to sync with Google we could use chrome.storage.local (opt-out), the API is identical to chrome.storage.sync but the data stays on the local computer.
Furthermore, I think syncing the difference between the default ruleset and the user ruleset would be the best option anyway.
With #1295 merged, we now declare the storage API in the manifest.
I agree the RE the privacy implications here -- users who don't want HTTPSe rule status synced between computers probably aren't signed into Chrome in the first place -- in which case Chrome defaults to chrome.storage.local.
If I'm not mistake, getStoredUserRules in chromium/background.js loads only manually entered rules. Also, addNewRule adds a new rule to the local storage. If that is correct, then it should be easy to use Chrome's API to store the user-added rules in the cloud. In other words, we don't really need to "only sync diffs to the default rules set".
That's correct. We're also talking about the ability to enable or disable a ruleset. It would be nice if the "is this ruleset enabled" bit could be synced, but only for rulesets where the enable/disable status is different than the default.
Activity
reedy commentedon Feb 15, 2015
You mean between multiple computers when logged in with your google account?
[-]Sync[/-][+]Sync extra rules and enabledness between multiple machines using the same google accoun[/+][-]Sync extra rules and enabledness between multiple machines using the same google accoun[/-][+]Sync extra rules and enabledness between multiple machines using the same google accountt[/+][-]Sync extra rules and enabledness between multiple machines using the same google accountt[/-][+]Sync extra rules and enabledness between multiple machines using the same google account[/+]fnkr commentedon Feb 15, 2015
Yes.
reedy commentedon Feb 16, 2015
I guess something similar could/should be done for FF sync too
diracdeltas commentedon Mar 8, 2015
This is probably a good idea; I think the % of chrome users who don't want to sync data between logged-in google-enabled Chrome profiles would be negligible.
Right now we use
window.localStorage. Switching that over to thechrome.storage.syncAPI should be easy.However, note that window.localStorage has 5MB of storage available per origin in Chrome, whereas chrome.storage.sync only lets HTTPS Everywhere have 100KB. That is probably not enough, unless you only sync diffs to the default rules set (user-added/enabled/disabeld rules).
fnkr commentedon Mar 8, 2015
For those people who dont want to sync with Google we could use
chrome.storage.local(opt-out), the API is identical tochrome.storage.syncbut the data stays on the local computer.Furthermore, I think syncing the difference between the default ruleset and the user ruleset would be the best option anyway.
semenko commentedon Mar 27, 2015
With #1295 merged, we now declare the
storageAPI in the manifest.I agree the RE the privacy implications here -- users who don't want HTTPSe rule status synced between computers probably aren't signed into Chrome in the first place -- in which case Chrome defaults to chrome.storage.local.
fnkr commentedon Mar 27, 2015
@privacy: If the user does not want Google to have the his data he is able to encrypt all synced data locally by setting a custom passpharse.
semenko commentedon Mar 27, 2015
Not yet -- no code has been written. Pull requests welcome if you'd like to help! :)
TheNavigat commentedon Aug 23, 2015
If I'm not mistake,
getStoredUserRulesinchromium/background.jsloads only manually entered rules. Also,addNewRuleadds a new rule to the local storage. If that is correct, then it should be easy to use Chrome's API to store the user-added rules in the cloud. In other words, we don't really need to "only sync diffs to the default rules set".Can someone confirm/explain this, please?
jsha commentedon Aug 23, 2015
That's correct. We're also talking about the ability to enable or disable a ruleset. It would be nice if the "is this ruleset enabled" bit could be synced, but only for rulesets where the enable/disable status is different than the default.
pipboy96 commentedon Mar 28, 2019
This is most likely already implemented since we always use synced storage if it's available.