Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

HTTPS-Everywhere retains the last ruleset after clicking on 'View image' #10039

Closed

Description

@Bisaloo

Take for example this stackexchange question.

When you right-click on any picture in this thread and select View image, you are linked to https://i.stack.imgur.com/.

If you then look at the active rulesets on that page:

  • The legacy XPCOM HTTPS-Everywhere lists Imgur.com
  • The new WebExtensions HTTPS-Everywhere lists Stack Exchange (partial) even though that ruleset is not active on that page. (I don't know if that fact it fails to mention Imgur.com is due to Full list of targets not displayed #9965 or not)

Related: #9958

Activity

  1. Hainish commented on Jun 9, 2017

    @Hainish
    Member

    For some reason, when we set the filter argument for https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/webRequest/onBeforeRequest to listen to all https urls and all http urls, onBeforeRequest isn't fired often in Firefox. Notably, it's not fired on page reloads or when you view an image.

    Changing this to the special string "<all_urls>" fixes this.

  2. Hainish commented on Jun 9, 2017

    @Hainish
    Member

    This has been fixed in https://github.com/EFForg/https-everywhere/tree/master because I want to make sure that this doesn't interfere with any chrome functionality. It really shouldn't, but just in case, it's better to get bug reports on the next release (before we deploy webextensions) than have to deal with all the problems at once when we merge the webextensions branch. The next test release will rebase from master, so you should be able to verify this when I deploy that.

  3. Hainish commented on Jun 9, 2017

    @Hainish
    Member

    Ref: 79ca764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions