Repository navigation
Conversation
bedroge
changed the title
1 task done
bedroge
marked this pull request as ready for review
November 3, 2026 16:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds in EESSI/software-layer#1862 are failing, because tests are apparently picking up binaries from the original installation, which is not wiped yet. Let's see if this will solve it.
Note: if it does, this needs some additional checks, and it should only be done in certain cases. Just kept it simple for now to be able to test it.The hook always runs, but I've added some safeguards: it only removes the existing dir if
--rebuildused, the dir already exists and is non-empty, and it requires you to set$EESSI_FORCE_EARLY_REMOVAL_OF_INSTALL_DIR=1. I've done the latter inEESSI-install-software.sh, but only for rebuilds, and only if the installpath starts with/cvmfs(to make sure that e.g. site builds on top of CVMFS also use this).