Repository navigation
Bump undici and @actions/github - #9
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [undici](https://github.com/nodejs/undici) to 6.24.1 and updates ancestor dependency [@actions/github](https://github.com/actions/toolkit/tree/HEAD/packages/github). These dependencies need to be updated together. Updates `undici` from 5.29.0 to 6.24.1 - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v5.29.0...v6.24.1) Updates `@actions/github` from 6.0.1 to 9.1.1 - [Changelog](https://github.com/actions/toolkit/blob/main/packages/github/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/github) --- updated-dependencies: - dependency-name: undici dependency-version: 6.24.1 dependency-type: indirect - dependency-name: "@actions/github" dependency-version: 9.1.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR intends to upgrade undici to v6.24.1 for security patches and @actions/github to v9.1.1. Codacy analysis indicates the PR is not up to standards. The upgrade of @actions/github from v6 to v9 introduces critical breaking changes: the package is now ESM-only (v9.0.0) and requires a minimum of Node.js 20 (v8.0.0). There is no evidence in the PR of transition logic for ESM or updates to the engine requirements. These issues represent major risks to application stability and should prevent merging in the current state.
About this PR
- @actions/github v9.0.0 is a breaking change that makes the package ESM-only. If the current project uses CommonJS (require), the application will crash at runtime. No code changes to adapt to ESM (e.g., dynamic imports) are present.
- The provided diff is empty regarding package.json changes, preventing verification of the dependency updates and their constraints.
- @actions/github v8.0.0+ requires a minimum of Node.js 20. There is no evidence that the project's environment or engines configuration has been updated to support this requirement.
Test suggestions
- Verify compatibility with ESM-only requirements introduced in @actions/github v9.0.0
- Verify compatibility with Node.js 20 minimum requirement introduced in @actions/github v8.0.0
- Verify that undici security patches do not break existing HTTP/WebSocket functionality
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify compatibility with ESM-only requirements introduced in @actions/github v9.0.0
2. Verify compatibility with Node.js 20 minimum requirement introduced in @actions/github v8.0.0
3. Verify that undici security patches do not break existing HTTP/WebSocket functionality
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
Bumps undici to 6.24.1 and updates ancestor dependency @actions/github. These dependencies need to be updated together.
Updates
undicifrom 5.29.0 to 6.24.1Release notes
Sourced from undici's releases.
... (truncated)
Commits
c0cf656Bumped v6.24.1f5a9f0cFix v6 release workflow branch targetingaf2cb8fwqremove maxDecompressedMessageSize (#4891)8873c94Bumped v6.24.0411bd01test(websocket): use node:assert for Node 18 compatibility844bf59test: fix http2 lint regressions in backporta444e4ftest: stabilize h2 and tls-cert-leak under current test runnerdc032a1fix: h2 CI (#4395)4cd3f4btest: increase bitness intest/fixtures/*.pem(#3659)7df6442fix: adapt websocket frame-limit handling for v6 parserMaintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for undici since your current version.
Install script changes
This version modifies
preparescript that runs during installation. Review the package contents before updating.Updates
@actions/githubfrom 6.0.1 to 9.1.1Changelog
Sourced from @actions/github's changelog.
Commits
Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for
@actions/githubsince your current version.You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.
This change is