Repository navigation
Conversation
kvinwang
force-pushed
the
codex/fix-guest-atomic-credentials
branch
from
August 4, 2026 07:49
cfba158 to
83076e6
Compare
Collaborator
Author
|
Closing because staging two files and renaming them sequentially does not make the certificate/key pair atomic: a crash, reader, or second rename failure can still observe a new certificate with the old key. The related #841 case was updated to validate certificate/key binding, permissions, individual output failures, and retry without asserting unsupported two-file transaction semantics. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Certificate and private key were replaced as separate writes. A crash or reader between the writes could observe a new certificate paired with the old key, causing TLS loading and handshakes to fail.
Root cause and fix
Stage the matching certificate/key outputs together and publish the pair through an atomic commit sequence.
Implementation
The branch records the following focused implementation work:
fix(util): stage certificate and key togetherChanged paths:
dstack/crates/dstack-cli-core/src/fsutil.rsdstack/dstack-util/src/main.rsScope
This PR addresses one logical
utilfinding. It intentionally excludes the acceptance-test infrastructure from #841 and unrelated product fixes from #840.Dependency and merge order
codex/fix-guest-atomic-credentialsVerification
git diff --check origin/codex/fix-guest-atomic-credentials..origin/codex/fix-util-atomic-cert-key: passed.