Skip to content

fix(guest): safely write attestation outputs - #889

Merged
kvinwang merged 1 commit into
masterfrom
codex/fix-guest-atomic-attestation-output
Aug 5, 2026
Merged

kvinwang merged 1 commit into
masterfrom
codex/fix-guest-atomic-attestation-output

Conversation

@kvinwang

@kvinwang kvinwang commented Jul 31, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Use the repository's existing safe-write dependency for attestation output files instead of maintaining another atomic-write implementation.

Changes

  • Write quote reports, encoded attestations, JSON attestations, and stripped attestations with safe_write::safe_write.
  • Support text and binary output through the library's existing byte-oriented API.
  • Remove the extra dstack-cli-core dependency and custom byte-write helpers from this PR.

Verification

  • cargo check --manifest-path dstack/Cargo.toml -p dstack-util
  • cargo fmt --manifest-path dstack/Cargo.toml --all
  • git diff --check

Copilot AI review requested due to automatic review settings July 31, 2026 02:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@kvinwang
kvinwang force-pushed the codex/fix-guest-atomic-credentials branch from cfba158 to 83076e6 Compare August 4, 2026 07:49
@kvinwang
kvinwang force-pushed the codex/fix-guest-atomic-attestation-output branch from 56ac09e to b927f81 Compare August 4, 2026 08:48
@kvinwang kvinwang changed the title [STACKED on #883] fix(guest): write attestation outputs atomically fix(guest): safely write attestation outputs Aug 4, 2026
@kvinwang
kvinwang changed the base branch from codex/fix-guest-atomic-credentials to master August 4, 2026 08:50
@kvinwang
kvinwang force-pushed the codex/fix-guest-atomic-attestation-output branch from b927f81 to 8f16974 Compare August 5, 2026 00:50
@kvinwang
kvinwang merged commit f0e4b6f into master Aug 5, 2026
15 checks passed
@kvinwang
kvinwang deleted the codex/fix-guest-atomic-attestation-output branch August 7, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants