Repository navigation
fix(dstack-mr-cli): pass num_nics, num_verity_volumes and swtpm to diagnose - #1367
Merged
Merged
Conversation
kvinwang
force-pushed
the
fix/dstack-mr-cli-diagnose-vm-shape
branch
from
September 24, 2026 09:02
e16a24c to
fb26f4d
Compare
kvinwang
changed the title
kvinwang
added a commit
that referenced
this pull request
Sep 25, 2026
… parser bounds #1387 requires PCI hotplug off for GPU passthrough, so the matrix GPU row failed; measure it with hotplug off and assert the named rejection without. #1229 reads XLF bit 1, not bit 6, for the initrd ceiling: fix the harness oracle and add a row with a 5-level-only kernel. #1367 made diagnose honour num_nics, num_verity_volumes and swtpm; compare it with measure. Run the new dstack-mr and dstack-types bound vectors from #1229, #1231, #1236 and Signed-off-by: Kevin Wang <wy721@qq.com> #1275 by exact name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
dstack-mr diagnosebuilds itsMachinefromVmConfigbut, unlike the verifier (verifier::compute_measurements), never setnum_nics,num_verity_volumesorswtpm. For a VM with a second NIC or verity volume it printed a plausible but wrong RTMR0, and forswtpm: trueit printed an RTMR0 where the verifier refuses to measure.Fix
Pass the three fields, matching the verifier's builder chain.
Verification
cargo clippy -p dstack-mr-cliandcargo fmt --checkclean. Diagnostic CLI only; no measurement code changed.Follow-up (not here): the
VmConfig -> Machinetranslation is duplicated in the verifier, the CLI anddstack-mr::tdx; one shared constructor would stop this drift.