Repository navigation
fix(dstack-util): write boot-time secrets owner-only - #1233
Merged
Merged
Conversation
This was referenced Sep 20, 2026
kvinwang
force-pushed
the
fix/guest-secret-file-modes
branch
from
September 24, 2026 09:08
ba47bdc to
6b24df5
Compare
kvinwang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The boot path wrote secrets with plain
fs::write, so they landed0644:.appkeys.json(disk/env keys, app root key, KMS temp CA key).get-keys/gen-app-keysalready write the same file0600..decrypted-envand.decrypted-env.json(plaintext deployer secrets).docs/security/security-best-practices.mdasks for0600on both.app-compose.servicereads them as root; containers get the values through compose, so nothing else changes.All three now go through
safe_write_with_mode(.., 0o600).The host-shared copy truncation that was originally in this PR has since landed on
next, so it was dropped on rebase.Verification:
cargo test -p dstack-util(113 passed), clippy and fmt clean.