Skip to content

Change execution method for configure - #9

Merged
phibos merged 1 commit into
DinoTools:masterfrom
pchaigno:master
Dec 17, 2014
Merged

phibos merged 1 commit into
DinoTools:masterfrom
pchaigno:master

Conversation

@pchaigno

Copy link
Copy Markdown
Contributor

When installing on Windows with setup.py using MinGW32, I got the following error:

'.' is not recognized as an internal or external command, operable program or batch file.
Failed while building ssdeep lib with configure and make.

This pull request changes the two pieces of code calling configure to use sh instead of a direct execution.

When installing on Windows, depending on the environment, it sometimes don't understand './configure'.
Using sh directly should work on all platforms.
phibos added a commit that referenced this pull request Dec 17, 2014
src - Change execution method for configure
@phibos
phibos merged commit af35c11 into DinoTools:master Dec 17, 2014
@phibos

phibos commented Dec 17, 2014

Copy link
Copy Markdown
Member

Thanks.

Would be nice if you could add a short description on how to build the python module on Windows to the documentation.

@pchaigno

Copy link
Copy Markdown
Contributor Author

This error was preventing the installation on Windows using pip. If you update the package on PyPI it may work now...

I tried to install it from sources only because I though it may be easier (I wasn't sure an installation through pip was possible on Windows).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants