Skip to content

Support custom placeholders in templates - #101

Draft
tpoliaw wants to merge 2 commits into
mainfrom
custom_placeholders
Draft

tpoliaw wants to merge 2 commits into
mainfrom
custom_placeholders

Conversation

@tpoliaw

@tpoliaw tpoliaw commented Feb 12, 2025 •

Copy link
Copy Markdown
Collaborator

Still to figure out

  • What to do if a key is missing
  • How to handle invalid values
    • sample_name = 'name/../../otherdirectory'
    • sample_name = '\x02\x04\x10'
  • Whether this should only apply to detector templates or the main scan file as well
  • Probably many other things

@tpoliaw
tpoliaw force-pushed the custom_placeholders branch from 1efa71c to 598cc85 Compare August 26, 2025 15:28
@codecov

codecov Bot commented Oct 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.18%. Comparing base (b8b38d9) to head (39d6263).

Files with missing lines Patch % Lines
src/graphql/mod.rs 11.11% 8 Missing ⚠️
src/paths.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   79.50%   79.18%   -0.32%     
==========================================
  Files          13       13              
  Lines        2132     2143      +11     
==========================================
+ Hits         1695     1697       +2     
- Misses        437      446       +9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants