Skip to content

feat(automation): sign config-sync and APM PR commits through the API - #538

Merged
DevSecNinja merged 1 commit into
mainfrom
devsecninja-feat-signed-automation-commits
Nov 16, 2026
Merged

DevSecNinja merged 1 commit into
mainfrom
devsecninja-feat-signed-automation-commits

Conversation

@DevSecNinja

Copy link
Copy Markdown
Owner

Description

config-sync, apm-sync and apm-materialize open their PRs with open-pr v3.3.0, which pushes unsigned commits. Every one of those PRs is then blocked by the required_signatures ruleset (for example DevSecNinja/note-iq#39 and DevSecNinja/vidaud#186). This PR bumps open-pr to v4.1.0, which includes #517, and sets commit-method: api. GitHub signs commits made through createCommitOnBranch, both with the Automation App token and with the GITHUB_TOKEN fallback.

Because open-pr no longer runs git push in these jobs, the calling-repository checkouts now use persist-credentials: false. That also removes their zizmor: ignore[artipacked] suppressions. No other step in these jobs needs git credentials: gh uses GH_TOKEN, and apm fetches packages into its own clones.

Fleet rollout: a repo picks this up once its config-sync.yml caller pin moves to the release that contains this PR. After that, gh workflow run config-sync.yml -R DevSecNinja/<repo> replaces the unsigned commit on chore/config-sync with a signed one in the same PR, even when the synced files haven't changed (#517 replaces an identical but unsigned tip).

Refs #488

Changes

  • .github/workflows/config-sync.yml, apm-sync.yml, apm-materialize.yml: open-pr pin v3.3.0 → v4.1.0 (5cee546), commit-method: api, and persist-credentials: false on the calling-repository checkout.
  • docs/automation-app.md: notes that these workflows' commits are signed, including on the GITHUB_TOKEN fallback.

Changes to open-pr itself between the two pins: #484 (create missing labels) and #517 (commit-method).

Validation

  • uv run --script tests/app-key-confinement.py: passed (32 workflows; the emptiness-check hashes are unchanged).
  • bash tests/automation-app-contract.sh, open-pr-api-commit.sh, open-pr-push.sh, open-pr-labels.sh, config-sync-ai-toolkit-instructions.sh, lint-job-modes-contract.sh, release-please-auth-contract.sh, copilot-model-policy-contract.sh, pages-custom-domain-contract.sh: passed. python3 tests/workflow-job-conditions.py: passed.
  • Not run locally because the tools are blocked on this machine (pyjson5, gitleaks and dprint inside WSL): the renovate-*, config-sync-renovate-stub, config-sync-lint-excludes, gitleaks-config and lint-gitleaks-report tests. This PR doesn't touch them, and CI runs mise run test.
  • zizmor --offline, yamllint, yamlfmt -lint on the three workflows and dprint check on the doc: clean.

Checklist

  • Linting passes locally. This repo has no lefthook config, so I ran the linters one by one (see above).
  • Commit messages follow Conventional Commits
  • Documentation updated (if applicable)

config-sync, apm-sync and apm-materialize opened their PRs with open-pr
v3.3.0, which pushes unsigned commits, so every one of those PRs is
blocked by the required_signatures ruleset. Bump open-pr to v4.1.0 and
set commit-method: api, so GitHub signs the commits (with the App token
and with the GITHUB_TOKEN fallback).

open-pr no longer runs git push in these jobs, so the calling-repository
checkouts stop persisting credentials and drop their zizmor artipacked
ignores.

Refs #488

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 19d297ab-bfd8-4280-be89-e8fc7e8ddc06
Commits

Reviewing files that changed from the base of the PR and between 5cee546 and aff8d2a.

Files selected for processing: 4

  • .github/workflows/apm-materialize.yml
  • .github/workflows/apm-sync.yml
  • .github/workflows/config-sync.yml
  • docs/automation-app.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the signed-commit workflow changes.

No open issues 🎉

What changed in this PR

This PR enables GitHub-signed commits for the shared config-sync and APM PR workflows, addressing the signed-commit requirement tracked in #488 using the API support added in #517.

Changes:

  • Upgrade open-pr from v3.3.0 to v4.1.0 and set commit-method: api in all three workflows.
  • Disable persisted checkout credentials and remove the associated security-linter suppressions.
  • Document signed commits, including when using the GITHUB_TOKEN fallback.
File Description
docs/​automation-app.md Document API-backed signing and fallback-token behavior.
.github/​workflows/​config-sync.yml Enable signed API commits and disable persisted checkout credentials.
.github/​workflows/​apm-sync.yml Enable signed API commits and disable persisted checkout credentials.
.github/​workflows/​apm-materialize.yml Enable signed API commits and disable persisted checkout credentials.

Review effort: Balanced

@DevSecNinja
DevSecNinja merged commit 5c662df into main Nov 16, 2026
34 checks passed
@DevSecNinja
DevSecNinja deleted the devsecninja-feat-signed-automation-commits branch November 16, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants