Skip to content

Use StyleProp for style properties - #28366

Merged
DanielRosenwasser merged 1 commit into
masterfrom
fix-bad-assignments-react-user-code
Aug 25, 2018
Merged

DanielRosenwasser merged 1 commit into
masterfrom
fix-bad-assignments-react-user-code

Conversation

@sandersn

Copy link
Copy Markdown
Contributor

Use StyleProp for style properties in react-native-swiper and react-native-sortable-list. This correctly handles properties created by StyleSheet.create.

@typescript-bot

typescript-bot commented Aug 24, 2018 •

Copy link
Copy Markdown
Contributor

@sandersn Thank you for submitting this PR!

🔔 @sivolobov @RookY2K @caihuan @huhuanming @mhcgrq - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@huhuanming huhuanming left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Aug 25, 2018
@typescript-bot

Copy link
Copy Markdown
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@DanielRosenwasser
DanielRosenwasser merged commit 02f7058 into master Aug 25, 2018
@DanielRosenwasser
DanielRosenwasser deleted the fix-bad-assignments-react-user-code branch August 25, 2018 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Owner Approved A listed owner of this package signed off on the pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants