Skip to content
This repository was archived by the owner on Sep 14, 2019. It is now read-only.
This repository was archived by the owner on Sep 14, 2019. It is now read-only.

The get*() methods that are used to access SmartDashboard can fail silently #21

Open
Open
The get*() methods that are used to access SmartDashboard can fail silently#21
Assignees
dfang314

Description

@brettle
brettle
opened on Jan 16, 2018

I'm referring to methods like this one:

RobotCode2018/Robot2018/src/org/usfirst/frc/team199/Robot2018/OI.java

Lines 56 to 61 in 1b3045f

public int getButton(String key, int def) {
if (!SmartDashboard.containsKey(key)) {
SmartDashboard.putNumber(key, def);
}
return (int) SmartDashboard.getNumber(key, def);
}

Consider what happens if there is already an entry with the requested key but it is of a different type.

Activity

  1. brettle commented on Jan 16, 2018

    @brettle
    brettle
    on Jan 16, 2018
    MemberAuthor

    The get*() methods that are used to access SmartDashboard can fail silently

  2. dfang314 commented on Jan 17, 2018

    @dfang314
    dfang314
    on Jan 17, 2018
    Contributor

    It would just return the default. However, this should never be the case since the convention I already set (and tbh will most likely change, this is one great reason why it shouldn't change) is greatly specific ("such as 'Button/Shift Drive' or 'Port/LeftTalonSRXDrive' [the booleans are a separate matter that will be dealt with (hopefully) tomorrow to the existing standard]) therefore imo at least there is no worry about overlap of keys. (Sorry for so many parentheses so here's some more)

  3. brettle commented on Jan 17, 2018

    @brettle
    brettle
    on Jan 17, 2018
    MemberAuthor

    "this should never be the case" + "convention" + Murphy's Law = "this is bound to happen at some point"

    My concern here is with the fact that there is no indication that this unexpected condition has occurred. Simply logging the error is sufficient.

  4. lhmcgann
    assigned
    dfang314
    on Feb 10, 2018

  5. dfang314 commented on Feb 10, 2018

    @dfang314
    dfang314
    on Feb 10, 2018
    Contributor

    Added printing to Standard Error in last commit (currently in a pull request)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions