Skip to content

update sidebar - #154

Open
banana-piecake wants to merge 32 commits into
Datapack-Hub:mainfrom
banana-piecake:main
Open

banana-piecake wants to merge 32 commits into
Datapack-Hub:mainfrom
banana-piecake:main

Conversation

@banana-piecake

Copy link
Copy Markdown
Contributor

no clue why there are 31 commits, its just the latest one

added on_consume method
fixed a lot of small formatting errors
fixed more formatting errors
fixed again
fixed a small error
fixed inconsistent comment formatting
added sidebar
swapped icon to apple as it uses a similar method to consumable components and won't be confused with carrot on a stick
updated main sidebar too
added myself to the credits cus im proud of myself :p
fixed the weird grammar
removed the con of slot changes, this is just not true
cleaned it up a bit
fixed missing period
fixed missing spaces in rightclick
removed unnecessary spaces
removed space
removed spaces
fixed incorrect mcfunction name
removed space
added info for mcfunction
split sentence
removed space
removed space
added an extra pro
forgot semicolon mb
fixed issue
added on_consume
@banana-piecake

Copy link
Copy Markdown
Contributor Author

i think its something to do with the way my last pull req was merged and i forgot to merge mine
image
thats the only commit i made recently

@HoodieRocks

Copy link
Copy Markdown
Contributor

Sorry about ghosting I've just been very busy as of recently

@Silabear Silabear left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to be harsh and suggest that this page is pointless. It would make much more sense to edit the consumable component page with information about how you could, in theory use on_consume instead of using_item, instead of having a separate page for what is effectively also using a consumable component.

Edit: I see this page already exists on the wiki (so i'm not entirely sure about the point of this pull request because you didn't really explain what its for), but I still stand by my point above

@banana-piecake

Copy link
Copy Markdown
Contributor Author

hello, sorry for the late reply, i've been out of the country
when i first suggested the page i also suggested it be on the consumable component page, but i was told that it might confuse people, as they use different advancements and page clutter may be too much (?), although i may be misremembering, it's been a while
as for the pull req, i forgot to state it when i originally made it, but it was to update the 1.21.10 sidebar to contain the page
for some reason it has 31 commits? i think it has to do with the way my first one was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants