Repository navigation
feat(docker/build-push)!: log in with username and password - #201
Merged
Merged
Conversation
antholzer
approved these changes
Nov 6, 2026
antholzer
left a comment
antholzer
left a comment
Contributor
There was a problem hiding this comment.
vars and secrets for the registry are usable by each repo in datalabhell?
Contributor
Author
yes, these are org wide secrets and vars, I will create them via ESO via k8s |
antholzer
approved these changes
Nov 10, 2026
chjdev
approved these changes
Nov 10, 2026
dan-n94
force-pushed
the
feat/build-push-without-vault
branch
from
November 10, 2026 11:04
0d95db8 to
be8caab
Compare
Contributor
Author
|
match the current approach with pushsecret from external secrets operator now: https://github.com/DataLabHell/k8s-deploy/pull/293 |
antholzer
approved these changes
Nov 10, 2026
antholzer
left a comment
antholzer
left a comment
Contributor
There was a problem hiding this comment.
Better separate PR for the python/publish changes?
…f vault
Any registry other than ghcr.io now takes its host as `registry` and logs in
with the new `username` and `password` inputs. The Vault step and the
`truenas` alias are gone, so callers no longer need `id-token: write`.
BREAKING CHANGE: `registry: truenas` is removed. Pass the host and
credentials from the org secrets:
registry: ${{ secrets.INTERNAL_OCI_REGISTRY_HOST }}
username: ${{ secrets.INTERNAL_OCI_REGISTRY_READWRITE_USERNAME }}
password: ${{ secrets.INTERNAL_OCI_REGISTRY_READWRITE_PASSWORD }}
dan-n94
force-pushed
the
feat/build-push-without-vault
branch
from
November 10, 2026 12:13
be8caab to
5c38d15
Compare
Contributor
Author
yes, good point, I'll do a dedicated one |
antholzer
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove vault
Any registry other than ghcr.io now takes its host as
registryand logs in with the newusernameandpasswordinputs. The Vault step and thetruenasalias are gone, so callers no longer needid-token: write.BREAKING CHANGE:
registry: truenasis removed. Pass the host and credentials instead: