Skip to content

Generate pup commands for SIEM historical jobs and histsignals - #990

Open
dd-octo-sts[bot] wants to merge 1 commit into
mainfrom
datadog-api-spec/generated/7458
Open

dd-octo-sts[bot] wants to merge 1 commit into
mainfrom
datadog-api-spec/generated/7458

Conversation

@dd-octo-sts

@dd-octo-sts dd-octo-sts Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

PLEASE, DO NOT MERGE THIS PULL REQUEST MANUALLY. This is automatically managed by Datadog Tooling

See ddoghq/datadog-api-spec#7458 Test branch datadog-api-spec/test/cgc/sec-40121-pup-annotations-for-siem-histo-80d23c62

@dd-octo-sts
dd-octo-sts Bot requested a review from a team as a code owner November 6, 2026 17:28
@dd-octo-sts dd-octo-sts Bot added the changelog/no-changelog Changes don't appear in changelog label Nov 6, 2026

@datadog-prod-us1-5 datadog-prod-us1-5 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: FAIL

Two critical compilation/runtime blockers are present: a duplicate run function definition in historical_jobs.rs that causes Rust error E0428, and a duplicate security subcommand registration in mod.rs that causes Clap to panic. Both must be resolved before the CLI can build or parse commands correctly.

Open Bits AI session

🤖 Bits Code Review · Commit c912b2a

/// Run a historical job
///
/// Run a historical job.
pub async fn run(cfg: &Config, file: &str) -> Result<()> {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Give the historical-job handler a distinct function name

This module already defines run(cfg: &Config, command: Command) as its dispatcher. Defining another run produces Rust error E0428 and prevents the CLI from compiling. Rename the historical-job operation handler and update the Command::Run call site together.

React: 👍 useful · 👎 wrong · 😕 unclear · 👀 right, but not acting on it

What each reaction means
  • 👍 Useful: correct, and you're fixing it or will.
  • 👎 Wrong: the finding is incorrect, for example the bug can't happen or the code was misread.
  • 😕 Unclear: you can't tell what it means or why it matters.
  • 👀 Right, not acting: correct, but intended, out of scope for this PR, a known risk, or too minor.

🤖 Bits Code Review · Open Bits AI session

Comment thread src/generated/mod.rs Outdated
action: domain_allowlist::Command,
},
/// Manage security resources
Security {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Merge generated actions into the existing security command

GeneratedCommand is flattened into the top-level parser, which already registers Commands::Security in src/main.rs. Once compilation is fixed, these duplicate security registrations cause Clap's debug validation to panic; the existing security parser also lacks the new historical-job and histsignal actions. Integrate the generated actions into SecurityActions and its dispatcher, following the existing downtime integration.

React: 👍 useful · 👎 wrong · 😕 unclear · 👀 right, but not acting on it

What each reaction means
  • 👍 Useful: correct, and you're fixing it or will.
  • 👎 Wrong: the finding is incorrect, for example the bug can't happen or the code was misread.
  • 😕 Unclear: you can't tell what it means or why it matters.
  • 👀 Right, not acting: correct, but intended, out of scope for this PR, a known risk, or too minor.

🤖 Bits Code Review · Open Bits AI session

@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Pipelines

✨ Unblock PR with BitsAI

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 2 Pipeline jobs failed

CI | Check, Test & Coverage — 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

CI | WASM (WASI + Browser) — 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f2f2a4b | Docs | View more details | Give us feedback!

@dd-octo-sts
dd-octo-sts Bot force-pushed the datadog-api-spec/generated/7458 branch 2 times, most recently from c8973e9 to c65d5d1 Compare November 7, 2026 16:26
@dd-octo-sts
dd-octo-sts Bot force-pushed the datadog-api-spec/generated/7458 branch from c65d5d1 to f2f2a4b Compare November 9, 2026 11:20

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog Changes don't appear in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants