Repository navigation
Generate pup commands for SIEM historical jobs and histsignals - #990
dd-octo-sts[bot] wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Two critical compilation/runtime blockers are present: a duplicate run function definition in historical_jobs.rs that causes Rust error E0428, and a duplicate security subcommand registration in mod.rs that causes Clap to panic. Both must be resolved before the CLI can build or parse commands correctly.
🤖 Bits Code Review · Commit c912b2a
| /// Run a historical job | ||
| /// | ||
| /// Run a historical job. | ||
| pub async fn run(cfg: &Config, file: &str) -> Result<()> { |
There was a problem hiding this comment.
Give the historical-job handler a distinct function name
This module already defines run(cfg: &Config, command: Command) as its dispatcher. Defining another run produces Rust error E0428 and prevents the CLI from compiling. Rename the historical-job operation handler and update the Command::Run call site together.
React: 👍 useful · 👎 wrong · 😕 unclear · 👀 right, but not acting on it
What each reaction means
- 👍 Useful: correct, and you're fixing it or will.
- 👎 Wrong: the finding is incorrect, for example the bug can't happen or the code was misread.
- 😕 Unclear: you can't tell what it means or why it matters.
- 👀 Right, not acting: correct, but intended, out of scope for this PR, a known risk, or too minor.
🤖 Bits Code Review · Open Bits AI session
| action: domain_allowlist::Command, | ||
| }, | ||
| /// Manage security resources | ||
| Security { |
There was a problem hiding this comment.
Merge generated actions into the existing security command
GeneratedCommand is flattened into the top-level parser, which already registers Commands::Security in src/main.rs. Once compilation is fixed, these duplicate security registrations cause Clap's debug validation to panic; the existing security parser also lacks the new historical-job and histsignal actions. Integrate the generated actions into SecurityActions and its dispatcher, following the existing downtime integration.
React: 👍 useful · 👎 wrong · 😕 unclear · 👀 right, but not acting on it
What each reaction means
- 👍 Useful: correct, and you're fixing it or will.
- 👎 Wrong: the finding is incorrect, for example the bug can't happen or the code was misread.
- 😕 Unclear: you can't tell what it means or why it matters.
- 👀 Right, not acting: correct, but intended, out of scope for this PR, a known risk, or too minor.
🤖 Bits Code Review · Open Bits AI session
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 2 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: f2f2a4b | Docs | View more details | Give us feedback! |
c8973e9 to
c65d5d1
Compare
c65d5d1 to
f2f2a4b
Compare
PLEASE, DO NOT MERGE THIS PULL REQUEST MANUALLY. This is automatically managed by Datadog Tooling
See ddoghq/datadog-api-spec#7458 Test branch datadog-api-spec/test/cgc/sec-40121-pup-annotations-for-siem-histo-80d23c62