Repository navigation
chore(deps): ignore mocha major versions - #414
Merged
Merged
Conversation
mocha 12 is ESM-only and requires Node ^20.19 || >=22.12. Its lib/cli/options.cjs require()s parse-args.js, an ES module, which only works via Node's require(esm) support — unflagged in 20.19+ and 22.12+, absent in 18. Since we still build and test on Node 18, every Node 18 job in #413 failed with ERR_REQUIRE_ESM. Stay on mocha 11 (which supports ^18.18.0 || ^20.9.0 || >=21.1.0) and ignore major bumps until we drop Node 18, mirroring the existing typescript clause.
szegedi
requested review from
IlyasShabi,
nsavoire and
r1viollet
as code owners
September 16, 2026 10:08
Overall package sizeSelf size: 2.62 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | pprof-format | 2.3.1 | 504.33 kB | 504.33 kB | | source-map | 0.8.0 | 185.66 kB | 185.66 kB | | node-gyp-build | 4.8.4 | 13.86 kB | 13.86 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
This comment has been minimized.
This comment has been minimized.
IlyasShabi
approved these changes
Sep 16, 2026
Merged
szegedi
added a commit
that referenced
this pull request
Oct 7, 2026
mocha 12 is ESM-only and requires Node ^20.19 || >=22.12. Its lib/cli/options.cjs require()s parse-args.js, an ES module, which only works via Node's require(esm) support — unflagged in 20.19+ and 22.12+, absent in 18. Since we still build and test on Node 18, every Node 18 job in #413 failed with ERR_REQUIRE_ESM. Stay on mocha 11 (which supports ^18.18.0 || ^20.9.0 || >=21.1.0) and ignore major bumps until we drop Node 18, mirroring the existing typescript clause.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mocha 12 is ESM-only (
"type": "module") and declaresengines: ^20.19.0 || >=22.12.0. Itslib/cli/options.cjsdoesrequire("./parse-args.js"), an ES module, which only works via Node'srequire(esm)support — unflagged in 20.19+ and 22.12+, absent in 18.Since we still build and test on Node 18, every Node 18 job in #413 failed with:
Node 20/22/24/25/26 pass; the failures are exclusively the
(18)matrix entries.So: stay on mocha 11 (
engines: ^18.18.0 || ^20.9.0 || >=21.1.0) and ignore major bumps until we drop Node 18, mirroring the existingtypescriptclause in the same file.We need to keep support for Node.js 18 until April 2027, when dd-trace-js v5.x reaches EOL.