Repository navigation
Move to libddwaf's handle API; remove metrics - #23
Merged
Merged
Conversation
cataphract
force-pushed
the
move-to-libddwaf
branch
11 times, most recently
from
August 26, 2021 15:03
9f5ab45 to
6e0f44d
Compare
cataphract
force-pushed
the
move-to-libddwaf
branch
from
August 26, 2021 15:10
6e0f44d to
5747bd5
Compare
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
============================================
- Coverage 66.03% 62.87% -3.17%
+ Complexity 76 74 -2
============================================
Files 26 24 -2
Lines 2264 1950 -314
Branches 86 88 +2
============================================
- Hits 1495 1226 -269
+ Misses 735 680 -55
- Partials 34 44 +10
Continue to review full report at Codecov.
|
cataphract
force-pushed
the
move-to-libddwaf
branch
from
August 26, 2021 15:59
97b8a51 to
ee3f1db
Compare
bantonsson
approved these changes
Aug 30, 2021
bantonsson
left a comment
Contributor
There was a problem hiding this comment.
I can't say that I've followed along on the libddwaf changes, but 👍 AFAICS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.