Skip to content

Move to libddwaf's handle API; remove metrics - #23

Merged
cataphract merged 3 commits into
masterfrom
move-to-libddwaf
Aug 30, 2021
Merged

cataphract merged 3 commits into
masterfrom
move-to-libddwaf

Conversation

@cataphract

Copy link
Copy Markdown
Contributor

No description provided.

@cataphract
cataphract force-pushed the move-to-libddwaf branch 11 times, most recently from 9f5ab45 to 6e0f44d Compare August 26, 2021 15:03
@codecov

codecov Bot commented Aug 26, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #23 (8bb7d35) into master (3e172ec) will decrease coverage by 3.16%.
The diff coverage is 64.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #23      +/-   ##
============================================
- Coverage     66.03%   62.87%   -3.17%     
+ Complexity       76       74       -2     
============================================
  Files            26       24       -2     
  Lines          2264     1950     -314     
  Branches         86       88       +2     
============================================
- Hits           1495     1226     -269     
+ Misses          735      680      -55     
- Partials         34       44      +10     
Impacted Files Coverage Δ
src/main/c/byte_buffer.c 100.00% <ø> (ø)
.../main/java/io/sqreen/powerwaf/NativeLibLoader.java 0.00% <0.00%> (ø)
src/main/java/io/sqreen/powerwaf/Powerwaf.java 86.53% <ø> (ø)
.../io/sqreen/powerwaf/logging/InfoToDebugLogger.java 36.36% <33.33%> (+5.59%) ⬆️
...c/main/java/io/sqreen/powerwaf/PowerwafHandle.java 60.00% <60.00%> (ø)
src/main/c/powerwaf_jni.c 69.44% <60.22%> (-4.75%) ⬇️
.../main/java/io/sqreen/powerwaf/PowerwafContext.java 83.33% <70.73%> (-15.13%) ⬇️
src/main/java/io/sqreen/powerwaf/Additive.java 75.00% <90.90%> (-5.00%) ⬇️
...en/powerwaf/exception/NoRulePowerwafException.java 0.00% <0.00%> (-100.00%) ⬇️
...erwaf/exception/UnclassifiedPowerwafException.java 33.33% <0.00%> (-33.34%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a37b210...8bb7d35. Read the comment docs.

@bantonsson bantonsson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say that I've followed along on the libddwaf changes, but 👍 AFAICS.

@cataphract
cataphract merged commit 704fab0 into master Aug 30, 2021
@cataphract
cataphract deleted the move-to-libddwaf branch August 30, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants