Repository navigation
AGENTS.md: add a mechanical comment-budget gate for agent sessions - #924
Merged
Merged
Conversation
Style rules ('lean', 'state each fact once') are review criteria that only
fire on self-re-judgment; agents skip them on fresh sessions. Add a
mechanical gate of the kind that already works in this file (the LOC
limits): <=3 lines per comment, one distinct constraint per line, prune
pass anchored to the finish step, per-line justification required beyond
the budget.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
CI Test ResultsRun: #41059256508 | Commit:
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled Summary: Total: 32 | Passed: 32 | Failed: 0 Updated: 2026-10-30 13:19:29 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Adds a comment budget gate to
AGENTS.md(Development Guidelines): before finishing any change, every comment and javadoc the agent wrote gets a prune pass — each comment ≤3 lines, one distinct constraint per line; anything longer requires per-line justification in the task summary. The same cut applies todoc/pages and PR descriptions.Motivation:
The existing comment rules ("lean", "state each fact once") are review criteria: they fire only if the agent spontaneously re-judges its draft, which does not reliably happen on fresh sessions. During PR #921 a 9-line comment block was written where 3 lines carried the constraint. Rules that hold across sessions in this repository are mechanical — countable limits checked at write time, anchored to an always-occurring step (compare the LOC limits enforced via
wc -lc). This gate follows that pattern: numeric budget, prune pass anchored to the finish step, explicit escalation for exceptions.Additional Notes:
Complements the existing comment rules; replaces nothing. Reverted out of #921 so repo-infra guidance rides its own PR.
How to test the change?:
Docs-only change (
AGENTS.md); no code paths affected.For Datadog employees:
credentials of any kind, I've requested a security review (run the
dd:platform-security-reviewskill, or file a request via the PSEC review form).
bewairealso runs automatically on every PR.