Repository navigation
fix(profiler): encode debug unwind event sizes as varints - #916
Conversation
CI Test ResultsRun: #41051492859 | Commit:
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled Summary: Total: 108 | Passed: 108 | Failed: 0 Updated: 2026-10-30 13:36:55 UTC |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
There was a problem hiding this comment.
More details
The reserved five-byte prefix matches the existing JFR varint writer, preserving event boundaries for long debug unwind-failure names without changing release behavior.
🤖 Bits Code Review · Commit 966e098
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 966e0983e9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
This comment will be updated automatically if new data arrives. 🔗 Commit SHA: d1b347f | Docs | View more details | Give us feedback! |
42d245a to
8a64173
Compare
8a64173 to
d1b347f
Compare
There was a problem hiding this comment.
More details
The reserved varint prefix accommodates bounded unwind-failure names while preserving event boundaries and diagnostic fields. Source review also found the continuation-truncation changes consistent with their callers and regression tests.
🤖 Bits Code Review · Commit 8a64173
What does this PR do?:
Encode debug unwind-failure event sizes with a multi-byte JFR varint.
Motivation:
Long runtime-stub names can exceed the one-byte event-size limit. Reserve a complete size prefix so debug recordings retain valid event boundaries instead of aborting or becoming unreadable.
Additional Notes:
How to test the change?:
Validation for
966e098, including the reviewed documentation-only prerequisite update:For Datadog employees: