Repository navigation
Quarantine flaky reference-chain slow e2e tests (PROF-16305) - #888
Merged
Merged
Conversation
The reference-chain slow e2e family fails intermittently in the nightly sanitized run 39893765385: the cache-leak test never observes a CachedPayload chain[0] (20 of ~32 eligible HotSpot 11+ debug/asan slow jobs), the two loose child-JVM variants report out-of-pool correlation tags, and the gc-root variant never observes a ChainLink chain[0] on musl-aarch64 JDK 11. Quarantine them against *-slow only, so failures in the regular suite still gate. The entries go away with the PROF-16305 fix PR (#800) once the tests are made reliable again.
Contributor
CI Test ResultsRun: #39938620060 | Commit:
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled Summary: Total: 32 | Passed: 32 | Failed: 0 Updated: 2026-10-23 10:45:41 UTC |
|
🔗 Commit SHA: a6da6bf | Docs | View more details | Give us feedback! |
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Adds four quarantine entries for the reference-chain slow e2e tests against PROF-16305, scoped to
*-slowcells. The failing tests keep running and reporting; only the nightly gating is suspended.Motivation:
Nightly Sanitized Runhas failed every night since 2026-10-20 (PR #800):ReferenceChainTrackingTest.shouldReconstructReferrerChainThroughUnboundedCacheLeakfails ~60% of eligible HotSpot 11+ debug/asan slow jobs (20 of ~32 in run 39893765385), plus intermittent failures ofshouldReconstructReferrerChainToGcRoot(musl-aarch64 11),ThreadLocalLeakReferenceChainTest.shouldCorrelateThreadLocalHeldLeakChain(3 jobs), andLeakTagCorrelationReferenceChainTest.shouldCorrelateLeakChainTargetTagWithLiveObjectLeakTag(1 job). The nightly signal is unusable until the tests are fixed; this restores it. Fix in progress under PROF-16305 — that PR removes these lines once verified.Additional Notes:
Intended to be merged before the fix PR, and superseded by it (its last act is deleting these entries).
How to test the change?:
python3 .github/scripts/quarantine.py validateand.github/scripts/tests/test_quarantine.shboth pass with the entries present.For Datadog employees:
credentials of any kind, I've requested a security review (run the
dd:platform-security-reviewskill, or file a request via the PSEC review form).
bewairealso runs automatically on every PR.