Repository navigation
Install a scrubbed JDK 21 for the okhttp exploration-tests image - #13132
eliottness wants to merge 1 commit into
Conversation
okhttp_5.3.x now needs a Java 21 toolchain. #13026 disabled Gradle toolchain auto-download (so Gradle cannot fetch an unscrubbed JDK), which made build-exploration-tests-image fail. Install Temurin 21 via SDKMAN; the existing cacerts scrub covers every SDKMAN JDK.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The JDK 21 installation matches Gradle’s configured toolchain path and is covered by the existing certificate-scrubbing step. The complete Docker image build remains unverified.
🤖 Bits Code Review · Commit 11e9e9e
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
What Does This Do
Installs Temurin 21 (
21.0.13.0+9-tem) through SDKMAN inDockerfile.exploration-testsand adds it to Gradle's toolchain paths.Motivation
#13026 (eMudhra CA remediation, APPSEC-71277) disabled Gradle toolchain auto-download so the build can't fetch a JDK whose
cacertsstill trusts the compromised roots. okhttp'sokhttp_5.3.xbranch now requires a Java 21 toolchain, so the manualbuild-exploration-tests-imagejob fails at./gradlew dependencieswith "Cannot find a Java installation ... matching languageVersion=21" (job 2195000692). The existing cacerts scrub step already covers every SDKMAN JDK, so JDK 21 is scrubbed too.Additional Notes
After merge,
build-exploration-tests-imageneeds to be run again on master. I will run it.