Repository navigation
Conversation
bric3
added
comp: tooling
ChatGPT Codex Connector
Contributor
Contributor
🟡 Java Benchmark SLOs — Performance SLO warning (near threshold)
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Debugger benchmarksParameters
See matching parameters
SummaryFound 5 performance improvements and 0 performance regressions! Performance is the same for 4 metrics, 6 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (385.248 µs) : 320, 450
. : milestone, 385,
basic (348.811 µs) : 343, 355
. : milestone, 349,
loop (8.931 ms) : 8745, 9118
. : milestone, 8931,
section candidate
noprobe (386.222 µs) : 352, 421
. : milestone, 386,
basic (351.275 µs) : 345, 358
. : milestone, 351,
loop (8.121 ms) : 8058, 8185
. : milestone, 8121,
|
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
bric3
force-pushed
the
bdu/jspecify-production
branch
from
October 28, 2026 10:03
53a778e to
1b12056
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adopt JSpecify in context, time, and version utilities. Enable NullAway's JSpecify mode, mark each production package, and describe nullable context array elements. Export the annotations through
apiso consumers can compile and analyse these contracts. Upgrade the SpotBugs analyser and annotations to 4.10.5 so override checks recognise JSpecify type annotations.Motivation
Standardise nullness contracts in the initial adopters and check nullable values inside generic types and arrays while preserving Java 8 reflection.
Additional Notes
Stacked on #13022. NullAway checking stays within the three initial modules. The downstream nullness repairs align contracts in
AgentSpanandScopeContextand update the shared test bootstrap setup.SpotBugs treats JSpecify
@Nullableas@CheckForNull, while JSR-305@Nullablehas weaker semantics. Both context overrides now use JSpecify@Nullableto keep the parent contract consistent.SpotBugs 4.10.5 includes the JSpecify override detector fix, allowing
AgentSpanto use JSpecify throughout. Upgrade repairs remove obsolete suppressions, document thread-confined cursors, and make the shared test timing field volatile.Important
queue-utilsretains the 4.10.4 analyser. SpotBugs 4.10.5 fails to converge while analysing inherited JCToolsfillmethods; 4.10.4 passes on the same inputs. The module keeps its existing checks.JSR-305 remains for other legacy nullness and concurrency annotations. JetBrains contracts, SpotBugs suppressions, and Forbidden APIs annotations retain their dependencies while consumers remain.
Java 8 type reflection requires the annotation classes to be visible to the loader of the annotated API. The test harness includes JSpecify in its bootstrap jar. The agent bundles one copy of the four annotations under
datadog.trace.bootstrap.jspecify.annotations, isolated from the application'sorg.jspecifyclasses.The dependency export and shared analyser reach many consumers. Lockfiles include JSpecify and the SpotBugs upgrade. Other dependency version changes are confined to the analyser configuration.
Compiling
@NullMarkedwith--release 8emits the knownElementType.MODULEwarning; see the JSpecify compatibility notes.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue