Repository navigation
Conversation
mcculls
added
comp: core
mcculls
force-pushed
the
mcculls/jnr-unixsocket-0.39.6
branch
from
October 23, 2026 12:46
e387ab8 to
e0811af
Compare
Debugger benchmarksParameters
See matching parameters
SummaryFound 6 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 6 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (363.18 µs) : 299, 427
. : milestone, 363,
basic (328.996 µs) : 323, 335
. : milestone, 329,
loop (8.907 ms) : 8720, 9094
. : milestone, 8907,
section candidate
noprobe (352.51 µs) : 310, 395
. : milestone, 353,
basic (319.882 µs) : 314, 326
. : milestone, 320,
loop (7.571 ms) : 7565, 7577
. : milestone, 7571,
|
mcculls
force-pushed
the
mcculls/jnr-unixsocket-0.39.6
branch
from
October 23, 2026 13:09
e0811af to
bcb2ae4
Compare
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
Update the JNR dependency stack and affected lockfiles. Add the no-op PatchLogger finest(Supplier<String>) overload required by the shaded JFFI StubLoader, with regression coverage ensuring lazy messages remain unevaluated. Trim unsupported JNR platform classes. Exclude JNR's transitive ASM dependencies and supply the controlled ASM 9.10.1 bundle, including utilities and analysis, to remain compatible with the core embedded in dd-instrument-java.
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
mcculls
force-pushed
the
mcculls/jnr-unixsocket-0.39.6
branch
from
October 23, 2026 14:08
bcb2ae4 to
f696271
Compare
bric3
approved these changes
Oct 23, 2026
bric3
reviewed
Oct 23, 2026
Comment on lines
+95
to
+96
| // JNR must use our controlled ASM version, matching the core embedded in dd-instrument-java. | ||
| dependencies.components.withModule('com.github.jnr:jnr-ffi') { |
Contributor
There was a problem hiding this comment.
suggestion: I'll document that using this mechanism edits the dependency metadata before resolution.
Suggested change
| // JNR must use our controlled ASM version, matching the core embedded in dd-instrument-java. | |
| dependencies.components.withModule('com.github.jnr:jnr-ffi') { | |
| // JNR must use our controlled ASM version, matching the core embedded in dd-instrument-java. | |
| // The following edits JNR-FFI's dependency metadata before resolution to remove ASM. | |
| dependencies.components.withModule('com.github.jnr:jnr-ffi') { |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Upgrade jnr-unixsocket from 0.38.25 to 0.39.6, including its JNR/JFFI dependencies and 487 affected lockfiles. Add the no-op
PatchLogger.finest(Supplier<String>)overload required by the shaded JFFI StubLoader, with regression coverage ensuring suppliers are not evaluated.Exclude JNR constant tables and FFI aliases for unsupported native platforms, preserving supported-platform tables, fallbacks, and classes referenced by shared factories.
Remove JNR's transitive ASM dependencies centrally and supply the catalog-controlled ASM 9.10.1 bundle explicitly. Include ASM utilities and analysis previously supplied transitively by JNR. This prevents ASM 9.11.1 helpers from referencing
LimitExceededException, which is absent from the ASM core embedded indd-instrument-java.Motivation
Pick up Unix datagram shutdown and address-handling fixes, native-library loading improvements, and transitive dependency updates while preserving agent logging isolation, ASM compatibility, and the agent JAR size budget.
Additional Notes
The rebuilt agent JAR is 34,530,363 bytes (32.93 MiB), below the 34 MiB budget.
Validation passed:
spotlessApplyandgit diff --check.InProductEnablementIntegrationTest.testDynamicInstrumentationResetEnablement, previously failing with the ASM mismatch.verifyAgentJarContents, including size and structural checks.TraceMethodVisitor(MethodVisitor)constructor lookup falls back as designed; that constructor is absent in both ASM 9.10.1 and 9.11.1.Earlier validation of the JNR upgrade also covered
PatchLoggerTest, shaded JFFI loading and native Unix socket creation, retained-class reference audits of the excluded platform classes, and reflective platform-selector checks. Those selector checks simulate platform profiles; they are not native execution on every platform.The token-gated Akka HTTP 10.6 module is excluded from the local build. Its lockfile was aligned manually with the verified dependency versions and was not independently resolved.
Contributor Checklist