Repository navigation
Condenser bar: stop its glyphs overlapping - #27
Merged
Merged
Conversation
The squeeze bar's jaws and core (triangles and a diamond) render wider than one cell in common terminal fonts and spill over the bar. Use box-drawing cells, which terminals draw to fit one cell exactly, for the live bar and the done marker, and test that the bar only uses those.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The condensing bar's jaws and core (
▸ ◂ ◆) render wider than one cell in common terminal fonts and spill over the bar.This uses box-drawing cells (
┣━━╋━━┫), which terminals draw to fit one cell exactly, for both the live bar and the done marker. A new test checks that the bar only uses those characters.Tests:
HOME=/tmp/nxhome-full npm test.