Repository navigation
Conversation
Nekkowe
changed the title
Nekkowe
changed the title
chdoc
left a comment
chdoc
left a comment
There was a problem hiding this comment.
This looks pretty good, the requested changes are mostly nitpicks.
| local material = "" | ||
|
|
||
| if df.item_type[square.item_type] == "WOOD" then | ||
| subtype = "wooden" |
There was a problem hiding this comment.
Not a strong preference, but I would prefer:
| subtype = "wooden" | |
| subtype = "wood" |
There was a problem hiding this comment.
With the precedent of "paved" for paved roads, I'd argue for "wooden" for wooden bridges here - the subtype attribute being an adjective makes for nicer labeling in GIS software.
(e.g. "construction_subtype" || " " || "construction_type" => "paved road", "wooden bridge", "stone bridge" etc.)
(The material attribute, of course, uses the noun; "peach wood", "willow", "mudstone" etc.)
SilasD
left a comment
SilasD
left a comment
There was a problem hiding this comment.
I think this is in good shape. chdoc covered my quibbles and more.
I did find one place the code could be more elegant. up to you if you change it.
…nsistency in table key syntax
3 participants
This PR addresses the position of bridges in the geodata export (as discussed on Discord), pinpointing them down to the midmap tile rather than the world tile as before.
As a result, they now correctly coincide with roads crossing rivers (diamonds = old, starbursts = new):
It also adds an attribute for the exact materials of bridges and roads (e.g. mudstone, pear wood, willow...) using dfhack.matinfo.decode/2 for the names.