Repository navigation
PhysicalDevice base class - #2
Merged
Merged
Conversation
Added doTurnOn, doTurnOff, doSetPower and doGetPower functions
Modified replyPatterns and
…e functional. Finally completed the code for PhysicalDevice implementation.
re-opening is an error, but closing twice is not (in pySerial). We do the same.
Added comments to errors when tests fail
More assertion to catch the occasional test failure: written data is not read back with real device.
Language is flush() to drop, drain() to wait until all trasnmitted/received.
Update to match documentation: OK when command does not return any values, Syntax error: cmd when command not recognized. All tests currently fail.
Added reply "OK" and Syntax error. NOt all tests pass.
Final modification so Syntax error is mimicked properly.
Collaborator
Author
|
@MaxenceLarose @Valeriouus : As observed in the laboratory, the protocol was incorrect: all commands return at least "OK" or "Syntax error : " (manual page. 24). The coboltDebugSerial.py was modified to match this behaviour, tests were all rewritten to also match this behaviour, and the coboltDevice.py was rewritten. Comments by @MaxenceLarose about turning off the laser were removed. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two important things: