Repository navigation
Setup: describe every setting, pick values from lists - #20
Merged
Merged
Conversation
… the sample's As bbs config got in D-Modem/bbs#57: - Every section and key has a description of what it does for the sysop (setupdesc.go); TestEverySettingDescribed keeps one for each key the sample has. F1 adds the sample's notes and the choices. - Keys are picked from lists with a note per value: closed lists (mode, tty, after, charset, driver, hash...), suggestions with "Type another value…", and checkboxes for lists of several (auth, [menu] items, dropfile, users, groups, aol networks, ppp_pool dns). The values come from the file and the machine: the items, the users file, [groups], /etc/passwd and /etc/group, resolv.conf, the sockets in /run. - An item's key list says which letters are free and which are taken by another item or the hangup; listen addresses say when the other section uses them. - "Add a menu item" starts from one of the sample's items (or an empty one), with a free key if the sample's is taken. - tui.ChooseMulti: a list of checkboxes. - The sample gains [number] deny and [sql] timeout, which the code read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B82eRVGabTrMWBpbnD6HKF
The server may hang up on a connection it is too busy for before the test writes its header: a broken pipe, which is the busy answer, not a failure. The loop that waits for the line to be free tries again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B82eRVGabTrMWBpbnD6HKF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Sydney · project thread
What
modemmenu -setup(andmode = setupitems) get the same treatmentbbs configgot in D-Modem/bbs#57, plus a description for every setting.password_promptshowed the banner's help,[item] usersshowed "bob these users ...",[item] commandshowed the PPP note). F1 adds the sample's notes and the list of values with their notes.TestEverySettingDescribedfails if a key in the sample has no description, or a description is left for a key that is gone.mode,tty,after,door_sys_lines,charset,petscii,driver,hash,update_hash,args,emulation,comm_type,fullscreen,password_change, every yes/nomin_baud,rate,security,com_port,socket_mode,host,port,terminal,pam_service...[general] auth,[menu] items,[item] dropfile,users,groups,[aol] networks,[ppp_pool] dns,[authd] allow_users,[system] groups[groups]with members,/etc/passwdlogin accounts,/etc/group, resolv.conf, sockets in /run/modemmenu and /run/bbs.free,taken by [item x]orthe hangup.listenpaths say when the other section uses them.[menu] items, and it gets a free key when the sample's is taken.tui.ChooseMulti: a list of checkboxes.[number] denyand[sql] timeout(read by the code, missing from the sample, so the setup didn't show them).docs/reference.mdregenerated;docs/setup.mdhas a "Values picked from what there is" section.Testing
go vet ./...andgo test ./...pass.TestEverySettingDescribed,TestSetupChoices(closed/multi/open, item and group notes, taken keys, F1 text),TestSetupMulti,TestSetupAddItem(template keys, free key,[menu] items, file still checks),TestItemTemplates, and checkbox cases intuiTestDialogs. The existingTestSetupkeystroke run still passes unchanged.modemmenu -setupin a pty with no config file and checked theauthcheckbox list on screen.Generated by Claude Code