Skip to content

Setup: describe every setting, pick values from lists - #20

Merged
Neo-Desktop merged 2 commits into
mainfrom
claude/project-thread-n7yldm
Nov 12, 2026
Merged

Neo-Desktop merged 2 commits into
mainfrom
claude/project-thread-n7yldm

Conversation

@Neo-Desktop

Copy link
Copy Markdown
Collaborator

Requested by Sydney · project thread

What

modemmenu -setup (and mode = setup items) get the same treatment bbs config got in D-Modem/bbs#57, plus a description for every setting.

  • Descriptions. Every section and key has a sentence or two on what it does, written for the sysop, shown under the bar. Before, many keys showed the sample's comment for a neighbouring key, or nothing (password_prompt showed the banner's help, [item] users showed "bob these users ...", [item] command showed the PPP note). F1 adds the sample's notes and the list of values with their notes. TestEverySettingDescribed fails if a key in the sample has no description, or a description is left for a key that is gone.
  • Pick lists with a note beside each value:
    • closed (nothing else accepted): mode, tty, after, door_sys_lines, charset, petscii, driver, hash, update_hash, args, emulation, comm_type, fullscreen, password_change, every yes/no
    • suggestions plus "Type another value…": log, time limits and warnings, min_baud, rate, security, com_port, socket_mode, host, port, terminal, pam_service...
    • checkboxes (Space checks, Enter done, order kept): [general] auth, [menu] items, [item] dropfile, users, groups, [aol] networks, [ppp_pool] dns, [authd] allow_users, [system] groups
  • From what's there: the file's items (with label and mode), the users file's users, [groups] with members, /etc/passwd login accounts, /etc/group, resolv.conf, sockets in /run/modemmenu and /run/bbs.
  • "Taken by" notes: an item's key list shows each letter of its name and label as free, taken by [item x] or the hangup. listen paths say when the other section uses them.
  • Add a menu item starts from one of the sample's 16 items (BBS by rlogin or handoff, PPP, change password, last callers, setup, a door, ZMODEM, ...) or an empty one. Its keys are filled in, it's added to [menu] items, and it gets a free key when the sample's is taken.
  • tui.ChooseMulti: a list of checkboxes.
  • The sample gains [number] deny and [sql] timeout (read by the code, missing from the sample, so the setup didn't show them). docs/reference.md regenerated; docs/setup.md has a "Values picked from what there is" section.

Testing

  • go vet ./... and go test ./... pass.
  • New: TestEverySettingDescribed, TestSetupChoices (closed/multi/open, item and group notes, taken keys, F1 text), TestSetupMulti, TestSetupAddItem (template keys, free key, [menu] items, file still checks), TestItemTemplates, and checkbox cases in tui TestDialogs. The existing TestSetup keystroke run still passes unchanged.
  • Ran modemmenu -setup in a pty with no config file and checked the auth checkbox list on screen.

Generated by Claude Code

… the sample's

As bbs config got in D-Modem/bbs#57:

- Every section and key has a description of what it does for the
  sysop (setupdesc.go); TestEverySettingDescribed keeps one for each
  key the sample has.  F1 adds the sample's notes and the choices.
- Keys are picked from lists with a note per value: closed lists (mode,
  tty, after, charset, driver, hash...), suggestions with "Type another
  value…", and checkboxes for lists of several (auth, [menu] items,
  dropfile, users, groups, aol networks, ppp_pool dns).  The values come
  from the file and the machine: the items, the users file, [groups],
  /etc/passwd and /etc/group, resolv.conf, the sockets in /run.
- An item's key list says which letters are free and which are taken by
  another item or the hangup; listen addresses say when the other
  section uses them.
- "Add a menu item" starts from one of the sample's items (or an empty
  one), with a free key if the sample's is taken.
- tui.ChooseMulti: a list of checkboxes.
- The sample gains [number] deny and [sql] timeout, which the code read.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B82eRVGabTrMWBpbnD6HKF
@Neo-Desktop Neo-Desktop self-assigned this Nov 12, 2026
The server may hang up on a connection it is too busy for before the
test writes its header: a broken pipe, which is the busy answer, not a
failure.  The loop that waits for the line to be free tries again.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B82eRVGabTrMWBpbnD6HKF
@Neo-Desktop
Neo-Desktop merged commit b027f77 into main Nov 12, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants