Repository navigation
Settings: the connection path at the top, as PCOMM draws its link - #51
Open
Neo-Desktop wants to merge 2 commits into
Open
Neo-Desktop wants to merge 2 commits into
Neo-Desktop wants to merge 2 commits into
Conversation
Settings now opens with how a call is made: the terminal (and what else shares the modem: dial-up internet, dial-in, the bridges), the modem, the line and what it reaches; for a modem of its own, the USB serial adapter or Bluetooth it's reached by, the modem and its line. Each step's role is above its icon and what it is below, one line joining them. Idle it shows the settings as they are (a step still to set in red, its line dashed, and a line saying what); starting, dialling and online it lights as the call goes. On Android a step opens its page. The shared Kotlin's ConnectionPath has the steps and their words, tested, for Android (Compose) and iOS (SwiftUI) alike. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B82eRTvKupDGEromPgYtjG
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B82eRTvKupDGEromPgYtjG
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Sydney · project thread
What
The top of Settings now shows how a call is made, modelled on PCOMM's "Connection Overview": four steps joined by one line, each with its role above the icon and what it is set to below.
The Terminal step also lists what else shares the modem: dial-up internet, dial-in and the bridges. While dial-up internet is up, that step shows as PPP.
How
shared/.../path/ConnectionPath.kt: the steps, their states and their wording, shared by Android and iOS, withConnectionPathTest.ui/ConnectionPathView.kt(Compose), placed above the settings menu's cards.ConnectionPathView.swift(SwiftUI), the first section of Settings. It covers iOS's lines: SIP, Wi-Fi and none.docs/features.mddescribes it.Tested
:shared:jvmTestpasses, including the 8 new path tests.:app:compileDebugKotlinbuilds with no warnings in the new code.The desktop apps get the same diagram in D-Modem/gui.
Generated by Claude Code