Repository navigation
api: executor version check polls up to the delay; multi-instance nodes keep the others' executors - #73
Merged
Conversation
…es keep the others' executors - checkExecutorVersion slept executor_check_version_delay (7 s on mainnet, 60 s in CI) on the node's start path and then asked once: it now asks every second (cs::pollUntil) and goes on as soon as the executor answers, with the same outcome as before when it never does (terminated); a transport error means not listening yet and is retried, any other answer is final; a stop is seen within a second. It stays on the launching thread (two threads opening the shared transport would be the new risk). The log line says how long the answer took. - Executor::stop() killed every contract-executor JVM of the machine (jps): with executor_multi_instance it now terminates only its own, as checkAnotherExecutor already does at start. The default keeps the official behaviour. Nothing here touches consensus. Found in the scale runs: every node start waited the full delay, and every restart test relaunched all the executors of the machine. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…'s answer in the version check getExecutorBuildVersion closes the connection on every exception, so 'still connected' never told an answer from a transport failure: it now sets ThriftException for a transport error (as execute() does), the poll retries only that, and the log says whether the executor never answered or answered with an error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
EnzinoBB
added a commit
that referenced
this pull request
Oct 22, 2026
…ter #73 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two non-consensus fixes found while analysing the slowdowns of the scale runs (#72).
Changes
checkExecutorVersionused to sleepexecutor_check_version_delay(7 s on mainnet, 60 s in CI) on the node's start path and then ask the executor once. It now asks every second withcs::pollUntiland continues as soon as the executor answers.Executor::stop()used to kill every contract-executor JVM on the machine (viajps). Withexecutor_multi_instanceset, it now terminates only its own executor, ascheckAnotherExecutoralready does at start. The default keeps the official behaviour.Nothing here is consensus-relevant. The plan and the lifecycle analysis come from Fable: the watcher thread cannot relaunch the JVM during the check, because at start it does not exist yet and on a relaunch it is the thread running the check.
Tests
tests/csnode/polluntil_tests.cpp: first success, last attempt at the deadline, early stop, zero delay.Validation
contracts=1: the "answered after N ms" lines, and executor relaunches in the sampler.contracts-crash,contracts-power-cut,contracts-pruned-term-kill.🤖 Generated with Claude Code