Repository navigation
csnode: check bootstrap round tables against the node's round and stall state - #71
Merged
Merged
Conversation
…d stall state - a table is taken only for a round next to the node's own: from its last block to its round + 2, the rounds an honest starter (last block + 1) sends to a node at most one block away or that learned the round (cs::isBootstrapRoundInWindow, csnode/bootstrapgate.hpp) - an unsigned table only once the node's own round has lasted half of round_elapse_time, the condition under which an honest node starts a bootstrap; a node younger than round_elapse_time or already in a bootstrap round takes it as before (cs::isBootstrapStallAccepted). RoundStat keeps the time of the last round change apart from the elapse tick - a table of initial confidants signed through the diag API is recognised by its signature and skips the stall check - the block-removal request derived from the table's round is gone: the permission flag it set is already set by every loaded or recorded block, so it never took effect - robustness.yml: node_alt_ref input, mixed binaries as in testnet.yml Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…le, docs precision, tests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardening of
Node::getBootstrapTable. It is stacked on #70; the base will becomemasteronce #70 is merged.Changes
cs::isBootstrapRoundInWindowincsnode/include/csnode/bootstrapgate.hpp.round_elapse_time, which is the condition under which an honest node starts a bootstrap. A node younger thanround_elapse_time, or already in a bootstrap round, takes the table as before.RoundStatnow keeps the time of the last round change separately from the elapse tick.robustness.yml: newnode_alt_refinput, for mixed binaries as intestnet.yml.Sending is unchanged, and honest tables always pass both checks, so a mixed network makes the same choices as before.
Validation
node_alt_ref=master(official receiver behaviour on the even nodes).mixed-power-cut,rocksdb-power-cut,net-partitionandchaos-mixed, plusmixed-power-cutwithnode_alt_ref=master.does not fit this nodeorms old ... droplines on honest traffic.🤖 Generated with Claude Code