Repository navigation
solver: log the stage3 inputs line only when a stage-3 check fails - #168
Merged
Merged
Conversation
The "stage3 inputs" line of #167 was written at info level for every stage 3, about one line a second on a trusted node. It is now kept for the round and written at info level once per iteration, just before the first "stage3 check failed" line, so both sides of a split still print it for the same round; at debug level it is still written every round. The other diagnostics of #167 already appear only when something goes wrong. Logging only: nothing signed, sent, stored or compared changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #167, to keep a healthy node's log quiet.
stage3 inputswas logged at info level for every stage 3, which is about one line a second on a trusted node. It is now kept for the round (stage3InputsLine_, diagnostics only, cleared innextRound) and logged at info level once per iteration, right before the firststage3 check failedline. Both sides of a split therefore still print it for the same round, which is what the comparison needs.docs/consensus-diagnostics.mdnow says so.Logging only: nothing signed, sent, stored or compared changes.
🤖 Generated with Claude Code