Repository navigation
client: the snapshot commands print the configured log levels, not every debug record - #117
Merged
Merged
Conversation
…vels --download-snapshot, --import-snapshot and --export-snapshot end before Peer sets the logger up, so Boost.Log's default sink printed every record the import makes to the console: 684,000 debug and trace lines for one --download-snapshot on Linux (the Docker first start included). They now call logger::initialize with the configuration's logger settings, as a running node does, and clean up at the end; the log of the import goes to log/ like the node's. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
1 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--download-snapshot,--import-snapshotand--export-snapshotend beforePeersets the logger up, so Boost.Log's default sink printed every record the import makes to the console: about 684,000 debug and trace lines (86 MB of job log) for one--download-snapshoton Linux, the Docker first start included. They now calllogger::initializewith the configuration's logger settings, as a running node does, and clean up when they end. The import's log goes tolog/like the node's; the command's own report lines (download-snapshot: …,import-snapshot: …) are plain output and unchanged.Test plan
snapshot-download,snapshot-download-corrupt,snapshot-corrupt,snapshot-join,snapshot-join-format1: green🤖 Generated with Claude Code