Repository navigation
Build and test the node on Windows and macOS - #114
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
One header for files read and written at an offset, atomic writes, locks, curl runs and thread priority, with Windows and macOS branches, so that the node builds on both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…b on clang Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…links on Windows, 16 KB pages) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d after its files close, tests - reflection: the type name from __FUNCSIG__ under MSVC, without the class/struct keyword - snapshot builder: a failed build removes <S>.tmp once its files are closed (Windows keeps open files) - tests: LMDB closed before its folder is removed, map growth step large enough for 16 KB pages, the rapid-launch process stress case skipped on macOS Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
make-package.sh takes PACKAGE_OS=windows|macos: node.exe and a .zip on Windows, the JDK in jdk/ with executor_command pointing at it, a README note for each system. release.yml builds both nodes through build-platforms.yml and packages them with a pinned Eclipse Temurin 11; they stay workflow artifacts (PUBLISH_PLATFORMS=false) until a node on each system has matched the Linux state digests on mainnet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The packages of one Release run restore the published pruned snapshot with --download-snapshot and sync mainnet to its head; the state digests logged every 1000 blocks must match across the three systems. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The node builds and passes its unit tests on Windows (MSVC, x64) and macOS (Apple Silicon), in a new workflow
build-platforms.ymlnext to the Linuxbuild.yml. Packages for both systems come in a later PR.Code
lib/system/platform.hpp(new): one place for what was POSIX-only. It covers:db/.lock;storage_backend,storage_convert,dbcheckandsnapshot_exportuse it. Behaviour on Linux is unchanged.LockFileEx); before, it was a no-op there.<S>.tmponly after its files are closed, because Windows does not remove open files.__FUNCSIG__, without theclass/structkeyword.gmtime_son Windows.Build (CI only, submodules untouched)
CMAKE_POLICY_VERSION_MINIMUM=3.5for the bundled projects.ci/platform/blake2-portable.patchbuilds BLAKE2s from the reference code on ARM (the SSE code is x86 only; BLAKE2b would clash with libsodium). The output is the same by definition. A mainnet state-digest comparison will confirm it before any macOS package is published.-Werroris off.VERSIONtext file is removed in the checkout. On case-insensitive file systems it shadows the standard<version>header.Tests
Test plan
🤖 Generated with Claude Code