Repository navigation
build: vendor the CREDITSCOM maven artifacts and build without CREDITSCOM - #7
Merged
Merged
Conversation
…SCOM The only artifacts the build downloaded from the creditscom mvn-repo branches declared in the poms were com.credits.client:general:1.2 and com.credits.client:node_client:1.4 (jar and pom each, from the thrift-api-client branch). Copy them byte for byte, with their checksums, into third-party/mvn-repo, and mirror every repository except Maven Central to that directory with third-party/maven-settings.xml, which the workflow passes to every mvn call. The poms are unchanged. The workflow checks out smart-contract-api 677c567f from the EnzinoBB fork (branch build/reproducible-1518) instead of CREDITSCOM, uses a new Maven cache key so the first run resolves everything through the mirror, and fails if the Maven log mentions a creditscom or raw.github URL. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the build of executor build 1518 independent of anything CREDITSCOM hosts.
What came from CREDITSCOM
A cold, non-quiet debug run (38397547299,
-Bwithout-q, no Maven cache) showed that, of the threeraw.github.com/creditscom/*/mvn-repo/repositories the poms declare, only the thrift-api-client branch served anything the build used:com.credits.client:general:1.2(jar, pom)com.credits.client:node_client:1.4(jar, pom)Every other lookup there was a 404. That includes the
sc-apiandcontract-executorbranches and thejblake2RELEASE metadata, and those lookups cost about 30 s of timeouts. The parentcom.credits.client:api-client:nonecomes from the local install of EnzinoBB/thrift-api-client. The workflow also checked outCREDITSCOM/smart-contract-api.Changes
third-party/mvn-repo/: those four files, copied byte for byte with their.sha1/.md5from themvn-repobranch of CREDITSCOM/thrift-api-client (commit8ebdd22, 2019). The checksums are verified. Total size is 2.2 MB.third-party/maven-settings.xml: a mirrorvendoredwithmirrorOf*,!centralthat points tofile://${env.VENDORED_MAVEN_REPO}. Every repository except Maven Central therefore resolves only from the vendored directory. The poms are unchanged.build.yml:mvncall, including the thrift-api-client and smart-contract-api builds, uses-s third-party/maven-settings.xmlEnzinoBB/smart-contract-apiat the same commit677c567f(now also branchbuild/reproducible-1518there)-q, and a new step fails the job if the Maven log mentionscreditscomorraw.githubBUILDING.md,third-party/README.md: document the above.Validation
build/independent-deps: 38397978439 (cold cache), 38398402279, 38399252256. Each log showsgeneral-1.2andnode_client-1.4"Downloaded from vendored: file://…/third-party/mvn-repo/…", plus downloads fromcentral, and nothing else.eecd2b23(run 38382529108): 14050/14058 and 40/42 classes identical, with the same 8 + 2 differing classes. Only the jar names change (-b58becomes-b59, the commit count).MANIFEST.MFandgit.propertiesdiffer (commit id and count).Known pre-existing issue (not changed here)
The
module-info.classof the jar-with-dependencies assemblies (*-v0.8.4-b<N>.jar) is not deterministic.maven-assembly-plugin2.2-beta-5 sometimes adds the dependency set before the project classes. The first entry wins, so the fat jars sometimes carrysc-api-internal's ororg.eclipse.osgi's descriptor:eecd2b23code also got the wrong one in debug run 38397547299.This is the nondeterminism noted in
3abfffed. The compare step cannot show it, because the release'smodule-info.classdiffers anyway.Still on CREDITSCOM
Only the verification step that downloads the mainnet release tarball (
CREDITSCOM/nodereleases) to compare classes. It is the reference being compared against and is not needed to build.🤖 Generated with Claude Code