Skip to content

sc-api-support: do not attach the jar-with-dependencies assembly - #6

Merged
EnzinoBB merged 1 commit into
build/reproducible-1518from
fix/reactor-plain-jar
Oct 13, 2026
Merged

EnzinoBB merged 1 commit into
build/reproducible-1518from
fix/reactor-plain-jar

Conversation

@EnzinoBB

Copy link
Copy Markdown
Collaborator

With appendAssemblyId=false the attached assembly replaces the main
artifact file of sc-api-support, so within the reactor contract-executor
compiles against sc-api-support--b.jar instead of
sc-api-support-0.8.5.jar. That fat jar holds one module-info.class taken
either from sc-api-support or from sc-api-internal, and when it is the
latter javac fails with "module not found: com.credits.sc.api.support".
Keep the plain jar as the project artifact; the assembly is still built.

(cherry picked from commit 6c38193)

Testing

  • Debug matrix on branch ci/debug-module-resolution (run 38372925244), 12 runs per variant with -X.
  • Without the fix, 7 of 12 runs failed with module not found: com.credits.sc.api.support. Every failing run's fat jar carried the com.credits.sc.api.internal descriptor.
  • With the fix, 12 of 12 runs passed, including the runs where the assembly order came out the bad way.

Known remaining issue: the shipped fat jars still get either module-info.class, depending on the assembly order. At runtime they are loaded through Class-Path, where module-info is ignored.

🤖 Generated with Claude Code

With appendAssemblyId=false the attached assembly replaces the main
artifact file of sc-api-support, so within the reactor contract-executor
compiles against sc-api-support-<tag>-b<n>.jar instead of
sc-api-support-0.8.5.jar. That fat jar holds one module-info.class taken
either from sc-api-support or from sc-api-internal, and when it is the
latter javac fails with "module not found: com.credits.sc.api.support".
Keep the plain jar as the project artifact; the assembly is still built.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 6c38193)
@EnzinoBB
EnzinoBB merged commit eb49e67 into build/reproducible-1518 Oct 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant