Repository navigation
sc-api-support: do not attach the jar-with-dependencies assembly - #6
Merged
Merged
Conversation
With appendAssemblyId=false the attached assembly replaces the main artifact file of sc-api-support, so within the reactor contract-executor compiles against sc-api-support-<tag>-b<n>.jar instead of sc-api-support-0.8.5.jar. That fat jar holds one module-info.class taken either from sc-api-support or from sc-api-internal, and when it is the latter javac fails with "module not found: com.credits.sc.api.support". Keep the plain jar as the project artifact; the assembly is still built. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 6c38193)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With appendAssemblyId=false the attached assembly replaces the main
artifact file of sc-api-support, so within the reactor contract-executor
compiles against sc-api-support--b.jar instead of
sc-api-support-0.8.5.jar. That fat jar holds one module-info.class taken
either from sc-api-support or from sc-api-internal, and when it is the
latter javac fails with "module not found: com.credits.sc.api.support".
Keep the plain jar as the project artifact; the assembly is still built.
(cherry picked from commit 6c38193)
Testing
ci/debug-module-resolution(run 38372925244), 12 runs per variant with-X.module not found: com.credits.sc.api.support. Every failing run's fat jar carried thecom.credits.sc.api.internaldescriptor.Known remaining issue: the shipped fat jars still get either
module-info.class, depending on the assembly order. At runtime they are loaded throughClass-Path, wheremodule-infois ignored.🤖 Generated with Claude Code