Repository navigation
executor: refuse a root class the contract did not define - #5
Merged
Merged
Conversation
deploySmartContract and executeContractMethod confined the contract's root class (or the deserialized instance's class) with the contract permission set. When the contract's byte code names a class that already exists, the contract class loader returns that class, one of the executor's own or the JDK's, and it was confined for the whole process and every later call. Confine it only when its loader is a contract loader. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The previous commit skipped confinement when the root class (or the deserialized instance's class) came from outside the contract loader, which would run that class's code for the contract with the executor's own permissions. A valid contract's root class is always defined by its contract loader, so refuse the deploy or call instead: fail closed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With appendAssemblyId=false the attached assembly replaces the main artifact file of sc-api-support, so within the reactor contract-executor compiles against sc-api-support-<tag>-b<n>.jar instead of sc-api-support-0.8.5.jar. That fat jar holds one module-info.class taken either from sc-api-support or from sc-api-internal, and when it is the latter javac fails with "module not found: com.credits.sc.api.support". Keep the plain jar as the project artifact; the assembly is still built. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 6c38193)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deploySmartContract and executeContractMethod confined the contract's root class, or the deserialized instance's class, with the contract permission set.
When a contract's byte code names a class that already exists, the contract class loader returns that class. It is one of the executor's own classes or the JDK's, and it was confined for the whole process and for every later call.
A valid contract's root class is always defined by its contract loader, so the deploy or call is now refused instead.
An earlier version of this fix skipped the confinement in that case. The automated security review flagged that, because it would run the class for the contract with the executor's permissions. The second commit makes the fix fail closed.
Testing
test/compatible-fixes(all phase-1 executor fixes, commit 9647fe4) and the odd nodes the release executor; 17 of 17 contract calls as expected,CounterandLedgerstates equal on all 7 nodes.Compatible: valid contracts behave as before. A build with commits on top of 1518 needs a higher
executor_commit_maxin the node's config.ini.🤖 Generated with Claude Code