Skip to content

executor: always return node connections to the pool, retry reads once - #4

Merged
EnzinoBB merged 3 commits into
build/reproducible-1518from
fix/node-client-pool
Oct 13, 2026
Merged

EnzinoBB merged 3 commits into
build/reproducible-1518from
fix/node-client-pool

Conversation

@EnzinoBB

Copy link
Copy Markdown
Collaborator

callThrift returned the pooled connection only when the call succeeded or
threw a TException, so any other exception, or a Thread.stop of the calling
contract, leaked it. Return it on every outcome, as broken unless the call
succeeded.

A pooled connection to the node is never validated, so after a node restart
the first callback of a contract failed on that node only. Retry the
read-only callbacks (seed, contract binary, wallet id, balance, date) once
on a new connection after a transport error. SendTransaction is not retried.

Testing

  • Executor build on Actions (JDK 11.0.3).
  • Node testnet run 38374856915: the even nodes ran test/compatible-fixes (all phase-1 executor fixes, commit 9647fe4) and the odd nodes the release executor; 17 of 17 contract calls as expected, Counter and Ledger states equal on all 7 nodes.

Compatible: valid contracts behave as before. A build with commits on top of 1518 needs a higher executor_commit_max in the node's config.ini.

🤖 Generated with Claude Code

EnzinoBB and others added 3 commits October 13, 2026 10:50
callThrift returned the pooled connection only when the call succeeded or
threw a TException, so any other exception, or a Thread.stop of the calling
contract, leaked it. Return it on every outcome, as broken unless the call
succeeded.

A pooled connection to the node is never validated, so after a node restart
the first callback of a contract failed on that node only. Retry the
read-only callbacks (seed, contract binary, wallet id, balance, date) once
on a new connection after a transport error. SendTransaction is not retried.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With appendAssemblyId=false the attached assembly replaces the main
artifact file of sc-api-support, so within the reactor contract-executor
compiles against sc-api-support-<tag>-b<n>.jar instead of
sc-api-support-0.8.5.jar. That fat jar holds one module-info.class taken
either from sc-api-support or from sc-api-internal, and when it is the
latter javac fails with "module not found: com.credits.sc.api.support".
Keep the plain jar as the project artifact; the assembly is still built.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 6c38193)
@EnzinoBB
EnzinoBB merged commit 80261e5 into build/reproducible-1518 Oct 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant