Repository navigation
executor: always return node connections to the pool, retry reads once - #4
Merged
Merged
Conversation
callThrift returned the pooled connection only when the call succeeded or threw a TException, so any other exception, or a Thread.stop of the calling contract, leaked it. Return it on every outcome, as broken unless the call succeeded. A pooled connection to the node is never validated, so after a node restart the first callback of a contract failed on that node only. Retry the read-only callbacks (seed, contract binary, wallet id, balance, date) once on a new connection after a transport error. SendTransaction is not retried. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With appendAssemblyId=false the attached assembly replaces the main artifact file of sc-api-support, so within the reactor contract-executor compiles against sc-api-support-<tag>-b<n>.jar instead of sc-api-support-0.8.5.jar. That fat jar holds one module-info.class taken either from sc-api-support or from sc-api-internal, and when it is the latter javac fails with "module not found: com.credits.sc.api.support". Keep the plain jar as the project artifact; the assembly is still built. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 6c38193)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
callThrift returned the pooled connection only when the call succeeded or
threw a TException, so any other exception, or a Thread.stop of the calling
contract, leaked it. Return it on every outcome, as broken unless the call
succeeded.
A pooled connection to the node is never validated, so after a node restart
the first callback of a contract failed on that node only. Retry the
read-only callbacks (seed, contract binary, wallet id, balance, date) once
on a new connection after a transport error. SendTransaction is not retried.
Testing
test/compatible-fixes(all phase-1 executor fixes, commit 9647fe4) and the odd nodes the release executor; 17 of 17 contract calls as expected,CounterandLedgerstates equal on all 7 nodes.Compatible: valid contracts behave as before. A build with commits on top of 1518 needs a higher
executor_commit_maxin the node's config.ini.🤖 Generated with Claude Code