Repository navigation
ci: compare the contract results of the build with build 1518; executor-*-rc tags are pre-releases - #11
Merged
Conversation
…or-*-rc tags are pre-releases compare-results runs the token scenarios of EnzinoBB/node (ci/contracts/executor_harness.py) on the release executor and on the jars just built, through their Thrift interface with a stub of the node: deploys, calls and getters of v0/v1/v2 tokens, payable, emitted transactions, failing calls, contract code that never returns. Any answer that differs fails the job, and the release job needs it: nodes running different executors must agree on every result. A tag executor-<name>-rc<N> publishes a pre-release, which the set-up of the node packages (it downloads the latest release) does not pick.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci/contracts/executor_harness.pyfrom EnzinoBB/node (sparse checkout, Thrift definitions at the node's submodule commit) on both. Every answer (status, return value, state hashes, emitted transactions) must be the same; only the API-only token standard may differ. The release job now needs it.executor-<name>-rc<N>publishes the jars as a pre-release, so that the node packages' set-up (which downloadsreleases/latest) does not pick an executor before the node release that ships it.Depends on CreditsCommunity/node#132 for the harness comparing answers only (until it is merged, the harness on node master also compares the scenarios' expectations, which a fixed executor meets better).
Test plan
🤖 Generated with Claude Code