Skip to content

executor: listen on 127.0.0.1 by default - #1

Merged
EnzinoBB merged 3 commits into
build/reproducible-1518from
fix/bind-localhost
Oct 13, 2026
Merged

EnzinoBB merged 3 commits into
build/reproducible-1518from
fix/bind-localhost

Conversation

@EnzinoBB

Copy link
Copy Markdown
Collaborator

The Thrift server bound to every interface, so anyone who could reach port 9080 could deploy and run bytecode in the executor.

It now binds to contract.executor.host, which defaults to 127.0.0.1. That is where the node connects with its default executor_ip=localhost. A node that uses an executor on another host sets contract.executor.host=0.0.0.0 or the interface address.

Contract execution and results are unchanged. Until this is deployed, operators should block port 9080 from outside the host.

Testing

  • Executor build on Actions (JDK 11.0.3, as build 1518): only the changed classes differ from the release executor.
  • Node testnet run 38358519896 (EnzinoBB/node, branch testnet/mixed-executor) with executor_ref=test/compatible-fixes, which holds both executor fixes: the even nodes ran this executor and the odd nodes ran the release executor. Every call to Counter (API v0) and Ledger (API v3, payable, an inner class in the state) returned the expected value before and after the restart test, and all 7 nodes ended with the same state for both contracts and the same state digests up to sequence 1100.

Deploying a build with commits on top of 1518 needs a higher executor_commit_max in the node's config.ini, see BUILDING.md.

🤖 Generated with Claude Code

EnzinoBB and others added 3 commits October 13, 2026 08:39
The Thrift server bound to every interface, so anyone who could reach port
9080 could deploy and run bytecode in the executor. Bind it to
contract.executor.host, 127.0.0.1 unless configured, which is where the
node's default executor_ip=localhost connects. A node using an executor on
another host sets contract.executor.host=0.0.0.0 (or the interface address).

Contract execution and results are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With appendAssemblyId=false the attached assembly replaces the main
artifact file of sc-api-support, so within the reactor contract-executor
compiles against sc-api-support-<tag>-b<n>.jar instead of
sc-api-support-0.8.5.jar. That fat jar holds one module-info.class taken
either from sc-api-support or from sc-api-internal, and when it is the
latter javac fails with "module not found: com.credits.sc.api.support".
Keep the plain jar as the project artifact; the assembly is still built.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 6c38193)
@EnzinoBB
EnzinoBB merged commit a0532ed into build/reproducible-1518 Oct 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant