Repository navigation
executor: listen on 127.0.0.1 by default - #1
Merged
Merged
Conversation
The Thrift server bound to every interface, so anyone who could reach port 9080 could deploy and run bytecode in the executor. Bind it to contract.executor.host, 127.0.0.1 unless configured, which is where the node's default executor_ip=localhost connects. A node using an executor on another host sets contract.executor.host=0.0.0.0 (or the interface address). Contract execution and results are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With appendAssemblyId=false the attached assembly replaces the main artifact file of sc-api-support, so within the reactor contract-executor compiles against sc-api-support-<tag>-b<n>.jar instead of sc-api-support-0.8.5.jar. That fat jar holds one module-info.class taken either from sc-api-support or from sc-api-internal, and when it is the latter javac fails with "module not found: com.credits.sc.api.support". Keep the plain jar as the project artifact; the assembly is still built. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 6c38193)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Thrift server bound to every interface, so anyone who could reach port 9080 could deploy and run bytecode in the executor.
It now binds to
contract.executor.host, which defaults to127.0.0.1. That is where the node connects with its defaultexecutor_ip=localhost. A node that uses an executor on another host setscontract.executor.host=0.0.0.0or the interface address.Contract execution and results are unchanged. Until this is deployed, operators should block port 9080 from outside the host.
Testing
testnet/mixed-executor) withexecutor_ref=test/compatible-fixes, which holds both executor fixes: the even nodes ran this executor and the odd nodes ran the release executor. Every call toCounter(API v0) andLedger(API v3, payable, an inner class in the state) returned the expected value before and after the restart test, and all 7 nodes ended with the same state for both contracts and the same state digests up to sequence 1100.Deploying a build with commits on top of 1518 needs a higher
executor_commit_maxin the node's config.ini, see BUILDING.md.🤖 Generated with Claude Code