Repository navigation
Add tests for basic.def.odr - #620
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #619
There are some cpp2rust bugs that I found while writing the tests:
p3.5-pointer-to-member.cpp- we don't support pointer to member yetp4.1-pure-virtual-qualified-call.cpp- unsupported inheritancep4.1-pure-virtual-member-pointer.cpp- pointer to memberp6-evaluated-binding-is-captured.cpp- structured binding not capturedp14.5.1-inline-function-reads-per-file-constant- converter generates one global, two globals must be generatedp15-function-template- static local is never initialisedI added tests only for behavioural differences between C++ and Rust. I ignored things that have to do with: ill formed programs, diagnostic required, clasue that only defines terms, etc.
I also caught a limitation in Clang in
p5.3-discarded-value-in-lambda.cpp, Clang captures a variable that it should not.