Address only the longer of two @names in a group, and not a Bot named by an email address - #708
Merged
davidmckayv merged 3 commits intoOct 2, 2026
Conversation
Chebaleomkar
requested review from
MikeRyanDev,
davidmckayv,
guidovizoso,
mxmzb and
tylerslaton
as code owners
October 2, 2026 19:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
mentionedPeersinserver/src/channels/group.tsmatched each Bot's@nameon its own:@Ops Lead please lookreturned both, because "Ops" followed by a space passes the lookahead. Insendboth Bots answered. Inrelaythe unintended Bot got a queued turn, an audit row and a fan-out slot.@, sowrite to jo@sam.comaddressed a Bot called Sam.Now an
@straight after a letter, digit or_is not a mention, and where two names match at the same@, only the longer one counts. The speaker is still matched, so its own longer name hides a shorter peer's, and it is still never returned.Where it runs
Server: group conversations, both a person's message (
send) and Bot-to-Bot relays.Boundary and audit
Fewer unintended relays, so fewer unintended
mayAddresschecks and audit rows. Depth and fan-out checks are unchanged.Changelog
Entry under Unreleased.
Proof
New test in
server/tests/group-conversations.test.ts. It fails onmain(3 pass, 1 fail) and passes with the fix (4/4). Servertscand Biome format and lint are clean.