Skip to content

copilot-core: Fix inaccurate Haddock comment of test property. Refs #787. - #794

Merged
ivanperez-keera merged 2 commits into
Copilot-Language:masterfrom
ivanperez-keera:develop-core-test-comment-diff-types
Nov 11, 2026
Merged

ivanperez-keera merged 2 commits into
Copilot-Language:masterfrom
ivanperez-keera:develop-core-test-comment-diff-types

Conversation

@ivanperez-keera

@ivanperez-keera ivanperez-keera commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Remove incorrect claim in the Haddock comment for copilot-core:Test.Copilot.Core.Type.testSimpleTypesInequality stating that the test is limited because it "[does] not test structs or arrays", as prescribed in the solution proposed for #787.

…opilot-Language#787.

The Haddock comment associated to
`copilot-core:Test.Copilot.Core.Type.testSimpleTypesInequality`
indicates that the test is limited because it "[does] not test structs
or arrays". However, the implementation of the test does include a
struct and an array. Haddock comments should accurately describe the
definitions they accompany.

This commit removes the claim that the test is limited because we do not
test structs or arrays from the Haddock comment for
`copilot-core:Test.Copilot.Core.Type.testSimpleTypesInequality`.
@ivanperez-keera
ivanperez-keera force-pushed the develop-core-test-comment-diff-types branch from 718d632 to 50def0f Compare November 11, 2026 13:41
@ivanperez-keera

Copy link
Copy Markdown
Member Author

Change Manager: Verified that:

  • Solution is implemented:
  • Implementation is documented. Details:
    Change is to the documentation.
  • Change history is clear.
  • Commit messages are clear.
  • Changelogs are updated.
  • Examples are updated. Details:
    No updates needed; change does not affect existing examples.
  • Author is internal or has provided signed CLA.
  • Required version bumps are evaluated. Details:
    Bump not needed; change is to the documentation and does not affect public API.

@ivanperez-keera
ivanperez-keera merged commit a1e177b into Copilot-Language:master Nov 11, 2026
12 checks passed
@ivanperez-keera
ivanperez-keera deleted the develop-core-test-comment-diff-types branch November 11, 2026 15:05
@ivanperez-keera
ivanperez-keera restored the develop-core-test-comment-diff-types branch November 11, 2026 15:05
@ivanperez-keera
ivanperez-keera deleted the develop-core-test-comment-diff-types branch November 11, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant