Repository navigation
CSSTUDIO-3793 Display of description in PV Table for values of type VEnum, VBoolean, and VString - #3967
Open
abrahamwolk wants to merge 4 commits into
Open
CSSTUDIO-3793 Display of description in PV Table for values of type VEnum, VBoolean, and VString#3967abrahamwolk wants to merge 4 commits into
VEnum, VBoolean, and VString#3967abrahamwolk wants to merge 4 commits into
Conversation
…Provider interface instead of the DisplayProvider interface in PV Table.
… String PVA values.
abrahamwolk
requested review from
georgweiss,
jacomago,
kasemir,
katysaintin,
marcoleorato-ess and
shroffk
October 19, 2026 12:09
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary. This pull request implements the display of description for values of types
VEnum,VBoolean, andVStringin the PV Table application in Phoebus. The implementation depends on the changes to theepics-vtypelibrary implemented in epics-base/epicsCoreJava#146.Handling the possible presence of
AdvancedEnumDisplayin values of typeVEnum. One complication in the implementation arises from the possible presence ofAdvancedEnumDisplayin instances ofVEnum. This is handled by a special case of theswitch-expression that computes the description inPVTableItem:phoebus/app/pvtable/src/main/java/org/phoebus/applications/pvtable/model/PVTableItem.java
Line 207 in 8d869c7
Testing. I have tested the change manually for instances of
VEnum,VBoolean, andVStringthat contain descriptions. I have not tested the changes for Tango values, since I don't know how to generate a Tango data source for testing.Dependency on changes in
epics-vtype. This merge request depends on the changes in epics-base/epicsCoreJava#146, and should not be merged before those changes have been merged, made part of a release, and the dependency onepics-vtypein this pull request has been updated to point to a release ofepics-vtypethat contains the changes.