Repository navigation
feat(build): fail early when a node's source file is missing - #692
Open
yadavchiragg wants to merge 1 commit into
Open
yadavchiragg wants to merge 1 commit into
yadavchiragg wants to merge 1 commit into
Conversation
mkconcore.py only logs 'Script ... not found' for a missing node source and still exits 0, so the generated study fails later at run time. concore build now checks the node labels against the source directory first and stops with the list of missing files. Pulled-container and port-only labels are skipped. Tests and docs included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a node's source file is missing from the source directory, mkconcore.py only logs
Script 'x.py' not found in sourcedir ...and still exits 0.concore buildreports success and the generated study fails later at run time (cp ./src/x.pyin the build script, or a node with no code).This affects 10 bundled workflows when built with their own directory as the source, e.g. testsou/test3.graphml, testsou/twopid.graphml, demo/generalcontrol.graphml, gi/stimeaextcon.graphml.
concore validatealready reports "Missing source file", butbuildnever calls it.Change
concore buildchecks node labels (ID:file.ext) against the source directory before running mkconcore and stops with the list of missing files, creating no output.CZ:cpymat) and port-only nodes (IN:) are skippedBehavior change
Builds that previously "succeeded" while logging errors now fail up front. Happy to add an opt-out flag if you prefer.
Testing