Skip to content

fix(cpp): keep key=value params with unquoted string values - #688

Open
bhuvan-somisetty wants to merge 2 commits into
ControlCore-Project:devfrom
bhuvan-somisetty:fix/cpp-params-unquoted-values
Open

bhuvan-somisetty wants to merge 2 commits into
ControlCore-Project:devfrom
bhuvan-somisetty:fix/cpp-params-unquoted-values

Conversation

@bhuvan-somisetty

Copy link
Copy Markdown

Fixes #687

c++ key=value params dropped everything when one value was a plain word (n=3;mode=fast). now it splits on ; and = directly, like python does. added a test.

also carries the small ci fix (test path + ubuntu-24.04 pin) so checks can go green.

The comma-in-value tryparam test wrote concore.params to in/1/, but
load_params reads from inpath + "1/concore.params" (in1/), so it never
found the file.

ubuntu-latest now resolves to 26.04, where setup-python has no 3.9
build. Pin the Python test matrix to ubuntu-24.04 so 3.9 keeps running.

Signed-off-by: bhuvan-somisetty <somisettybhuvan5@gmail.com>
load_params turned a=1;b=x into dict text and parsedict threw on the bare word, so every param was dropped. Split on ; and = directly instead, like the python side.

Signed-off-by: bhuvan-somisetty <somisettybhuvan5@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant