Repository navigation
fix(cpp): keep key=value params with unquoted string values - #688
Open
bhuvan-somisetty wants to merge 2 commits into
Open
bhuvan-somisetty wants to merge 2 commits into
bhuvan-somisetty wants to merge 2 commits into
Conversation
The comma-in-value tryparam test wrote concore.params to in/1/, but load_params reads from inpath + "1/concore.params" (in1/), so it never found the file. ubuntu-latest now resolves to 26.04, where setup-python has no 3.9 build. Pin the Python test matrix to ubuntu-24.04 so 3.9 keeps running. Signed-off-by: bhuvan-somisetty <somisettybhuvan5@gmail.com>
load_params turned a=1;b=x into dict text and parsedict threw on the bare word, so every param was dropped. Split on ; and = directly instead, like the python side. Signed-off-by: bhuvan-somisetty <somisettybhuvan5@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #687
c++
key=valueparams dropped everything when one value was a plain word (n=3;mode=fast). now it splits on;and=directly, like python does. added a test.also carries the small ci fix (test path + ubuntu-24.04 pin) so checks can go green.