Repository navigation
fix(docker): add Dockerfile.cpp so C++ nodes can build in docker mode - #686
Open
yadavchiragg wants to merge 1 commit into
Open
yadavchiragg wants to merge 1 commit into
yadavchiragg wants to merge 1 commit into
Conversation
mkconcore selects Dockerfile.cpp for .cpp nodes, but the template did not exist, so every docker build of a C++ workflow exited with a misleading 'not correct path to concore' error. Add the template, emit the g++ compile step and CMD like the Verilog path does, and narrow the bare except so a missing template names the actual file. Adds tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mkconcore.py picks
Dockerfile.cppfor.cppnodes in docker mode, but that template was never in the repo. Every docker build of a workflow with a C++ node exits with rc=1. The bareexcept:prints "…is not correct path to concore", which points at the wrong cause.Reproduce on current dev:
python3 mkconcore.py testsou/testSM1.graphml testsou out docker
Changes
Dockerfile.cpp(ubuntu:22.04 + g++, same layout asDockerfile.v)RUN g++ ./<source>andCMD ["./a.out"]for C++ nodes, matching the POSIX run scriptexcept:withexcept OSErrorand report the template that could not be readtests/test_docker_cpp.pyTesting
g++against the copied headers.