Skip to content

feat(cli): add concore run to start a built study - #683

Open
yadavchiragg wants to merge 1 commit into
ControlCore-Project:devfrom
yadavchiragg:feat/cli-run-command
Open

yadavchiragg wants to merge 1 commit into
ControlCore-Project:devfrom
yadavchiragg:feat/cli-run-command

Conversation

@yadavchiragg

@yadavchiragg yadavchiragg commented Nov 14, 2026 •

Copy link
Copy Markdown

Related to #682

Problem: the CLI has no command to start a built study. Users must cd into the output folder and run ./run by hand, and there is no clean way to run a study from a script or CI and know when it finished.

Change: new concore run <study_dir> command (concore_cli/commands/run.py, registered in cli.py):

  • --build runs the study's build script first and stops if it fails,
  • --wait waits until every node exits, using the pid files that POSIX/macOS run scripts write; Ctrl+C stops only that study's nodes,
  • --timeout <seconds> (with --wait) stops a study that runs too long,
  • exit codes: 0 success, 124 timeout, 130 interrupted, otherwise the failing script's exit code.

Pid files from earlier runs are ignored (checked by modification time). Docker and Windows builds do not record pids, so there --wait starts the study and prints a warning. --wait reports when nodes exit, not whether they succeeded; this is documented in concore_cli/README.md.

Testing: new tests/test_run_command.py (17 tests) covers start without waiting, waiting for nodes to finish, timeout, interrupt, build before run, failed build, stale pid files, exit-code propagation, and the CLI wiring. I also ran it on a real generated study (demo/sample.graphml, posix) with --wait on macOS. ruff format --check and ruff check are clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant