Repository navigation
feat(cli): add concore run to start a built study - #683
Open
yadavchiragg wants to merge 1 commit into
Open
yadavchiragg wants to merge 1 commit into
yadavchiragg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #682
Problem: the CLI has no command to start a built study. Users must
cdinto the output folder and run./runby hand, and there is no clean way to run a study from a script or CI and know when it finished.Change: new
concore run <study_dir>command (concore_cli/commands/run.py, registered incli.py):--buildruns the study's build script first and stops if it fails,--waitwaits until every node exits, using the pid files that POSIX/macOS run scripts write;Ctrl+Cstops only that study's nodes,--timeout <seconds>(with--wait) stops a study that runs too long,Pid files from earlier runs are ignored (checked by modification time). Docker and Windows builds do not record pids, so there
--waitstarts the study and prints a warning.--waitreports when nodes exit, not whether they succeeded; this is documented inconcore_cli/README.md.Testing: new
tests/test_run_command.py(17 tests) covers start without waiting, waiting for nodes to finish, timeout, interrupt, build before run, failed build, stale pid files, exit-code propagation, and the CLI wiring. I also ran it on a real generated study (demo/sample.graphml, posix) with--waiton macOS.ruff format --checkandruff checkare clean.